[Django] #28608: UserCreationForm and UserChangeForm model using get_user_model
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo | Owner: nobody
Collopy |
Type: | Status: new
Cleanup/optimization |
Component: | Version: master
contrib.auth | Keywords: user, custom user,
Severity: Normal | auth
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
{{{
class UserChangeForm(forms.ModelForm):
# ...
class Meta:
model = User
}}}
and
{{{
class UserCreationForm(forms.ModelForm):
class Meta:
model = User
}}}
could use `UserModel` instead of `User`. It is already defined in
https://github.com/django/django/blob/01c6a3e227b645e8dea97e9befecd23d1d3b8581/django/contrib/auth/forms.py#L20
and is used in other forms of the same package.
This would allow Django Registration and other packages that use these
forms to work out of the box. And it would allow using them with no need
to rewitte as specified at
https://docs.djangoproject.com/en/1.11/topics/auth/customizing/#custom-
users-and-the-built-in-auth-forms
--
Ticket URL: <https://code.djangoproject.com/ticket/28608>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage:
auth | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "patch.diff" added.
patch
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage:
auth | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "patch.diff" added.
patch
--
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo Collopy | Owner: nobody
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage:
auth | Unreviewed
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
This is a continuation of #19353.
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo Collopy | Owner: nobody
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
auth |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:2>
Django
-------------------------------------+-------------------------------------
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage: Accepted
auth |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => assigned
* needs_better_patch: 1 => 0
* owner: nobody => hui shang
Comment:
Since This ticket is related to
[https://code.djangoproject.com/ticket/28757 ticket 28757], I made the
changes for this ticket and ticket 28757 in the same commit.
[https://github.com/django/django/pull/9354 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo Collopy | Owner:
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: user, custom user, | Triage Stage: Accepted
auth |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"3333d935d2914cd80cf31f4803821ad5c0e2a51d" 3333d93]:
{{{
#!CommitTicketReference repository=""
revision="3333d935d2914cd80cf31f4803821ad5c0e2a51d"
Fixed #28757 -- Allowed using contrib.auth forms without installing
contrib.auth.
Also fixed #28608 -- Allowed UserCreationForm and UserChangeForm to
work with custom user models.
Thanks Sagar Chalise and Rômulo Collopy for reports, and Tim Graham
and Tim Martin for reviews.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo Collopy | Owner:
Type: | shangdahao
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
auth |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: closed => new
* has_patch: 1 => 0
* resolution: fixed =>
Comment:
In f3fa86a89b3b85242f49b2b9acf58b5ea35acc1f:
Fixed #29449 -- Reverted "Fixed #28757 -- Allowed using contrib.auth forms
without installing contrib.auth."
This reverts commit 3333d935d2914cd80cf31f4803821ad5c0e2a51d due to a
crash if USERNAME_FIELD isn't a CharField.
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo Collopy | Owner:
Type: | shangdahao
Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage: Accepted
auth |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Lemuel Formacil):
Another non-standard behavior of the `UserCreationForm` when used with a
custom user model is if the model has a `ManyToManyField` the form will
not save the value of the `ManyToManyField`. From the
[[https://docs.djangoproject.com/en/dev/topics/forms/modelforms/#the-save-
method|documentation]]:
> If your model has a many-to-many relation and you specify `commit=False`
when you save a form, Django cannot immediately save the form data for the
many-to-many relation. This is because it isn’t possible to save many-to-
many data for an instance until the instance exists in the database.
>
> To work around this problem, every time you save a form using
`commit=False`, Django adds a `save_m2m()` method to your `ModelForm`
subclass. After you’ve manually saved the instance produced by the form,
you can invoke `save_m2m()` to save the many-to-many form data.
However, the `UserCreationForm.save` method initially calls the form's
save method with `commit=False` but then doesn't call the `save_m2m`
method within the `if commit:` block. The save method should be something
like this so the form would behave as expected with custom user models
with a many-to-many relation:
{{{
def save(self, commit=True):
user = super().save(commit=False)
user.set_password(self.cleaned_data["password1"])
if commit:
user.save()
self.save_m2m() # added this call to work with models with
`ManyToManyField`s
return user
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo Collopy | Owner:
Type: | shangdahao
Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage: Accepted
auth |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Lemuel Formacil (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:7>
Django
-------------------------------------+-------------------------------------
Type: | Pandey
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage: Accepted
auth |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: shangdahao => Aman Pandey
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo Collopy | Owner:
Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage: Accepted
auth |
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Ülgen Sarıkavak (added)
Django
-------------------------------------+-------------------------------------
Reporter: Rômulo Collopy | Owner:
Type: | shangdahao
Cleanup/optimization | Status: new
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: user, custom user, | Triage Stage: Accepted
auth |
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
#35484 is a duplicate, this generally tracks the work to make the
UserAdmin work for custom user models 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/28608#comment:9>