[Django] #16192: Make unique_together error messages in ModelForms customizable
Django
-------------------------+----------------------------
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Forms
Version: 1.3 | Severity: Normal
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------+----------------------------
This is related to ticket #8913 and Google groups discussion:
http://groups.google.com/group/django-
developers/browse_thread/thread/6306fea94a537c3b
Allow developers to specify a unique_together custom error_message on
their model. This is more difficult than #8913 since the syntax is less
obvious. Should there be something in the Meta?
--
Ticket URL: <https://code.djangoproject.com/ticket/16192>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Type: New feature | Status: new
Milestone: | Component: Forms
Version: 1.3 | Severity: Normal
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+------------------------
Changes (by aaugustin):
* needs_docs: => 0
* needs_better_patch: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:1>
Django
Reporter: | Owner: nobody
leahculver | Status: new
Type: New | Component: Database layer
feature | (models, ORM)
Milestone: | Severity: Normal
Version: 1.3 | Keywords:
Resolution: | Has patch: 0
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* component: Forms => Database layer (models, ORM)
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:2>
Django
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Marboni):
Are you guys plan to fix it in 1.4?
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:3>
Django
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by aaugustin):
This ticket hasn't gotten much attention. Apparently, no one cares enough
to write a patch. Until someone does, the feature won't be implemented.
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:4>
Django
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by anonymous):
I think it should get the attention it deserves. Providing the checking of
the fields without allowing to use a proper error message is like buying a
car which an alarm but without a door.
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:5>
Django
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by glynjackson):
More attention please! Are there any plans for this yet? I'm not confident
enough yet to submit a patch but would like to work on this with someone.
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:6>
Django
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* version: 1.3 => 1.6
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:7>
Django
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: loic@… (added)
* has_patch: 0 => 1
* version: 1.6 => master
Comment:
@glynjackson, I've had a go at this, could you please check if it solves
your issue?
https://github.com/django/django/pull/2235
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:8>
Django
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* needs_docs: 0 => 1
Comment:
Looks reasonable to me, but needs documentation.
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:9>
Django
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by loic84):
@timo what kind of documentation do you have in mind? Just an entry in the
release notes?
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:10>
Django
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* needs_docs: 1 => 0
Comment:
Added documentation to the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:11>
Django
Reporter: leahculver | Owner: nobody
Type: New feature | Status: closed
Component: Database layer | Version: master
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"8847a0c601e4261823b1726b2db73eec2ac17940"]:
{{{
#!CommitTicketReference repository=""
revision="8847a0c601e4261823b1726b2db73eec2ac17940"
Fixed #16192 -- Made unique error messages in ModelForm customizable.
Overriding the error messages now works for both unique fields,
unique_together
and unique_for_date.
This patch changed the overriding logic to allow customizing
NON_FIELD_ERRORS
since previously only fields' errors were customizable.
Refs #20199.
Thanks leahculver for the suggestion.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/16192#comment:12>