[Django] #26450: Docs says label is "Save as" for the button that actually has the label "Save as new"
Django
"Save as new"
---------------------------------+--------------------
Reporter: giuliettamasina | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------
The documentation for the `save_as` option on ModelAdmin says the button
is labeled "Save as" while in fact it is labeled "Save as new":
{{{
If save_as is True, “Save and add another” will be replaced by a “Save as”
button.
}}}
https://docs.djangoproject.com/en/1.9/ref/contrib/admin/#django.contrib.admin.ModelAdmin.save_as
I guess this changed at some point and the docs were not updated at the
same time (can't find a ticket for that change at the moment.)
The docs should be updated to reflect the correct button label in at least
1.9. I will open a pull request for this.
--
Ticket URL: <https://code.djangoproject.com/ticket/26450>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
"Save as new"
Reporter: giuliettamasina | Owner:
| giuliettamasina
Type: Bug | Status: assigned
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by giuliettamasina):
* status: new => assigned
* needs_docs: => 0
* owner: nobody => giuliettamasina
* needs_tests: => 0
* needs_better_patch: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26450#comment:1>
Django
"Save as new"
Reporter: giuliettamasina | Owner:
| giuliettamasina
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by giuliettamasina):
* has_patch: 0 => 1
Comment:
Pull request is here: https://github.com/django/django/pull/6396
--
Ticket URL: <https://code.djangoproject.com/ticket/26450#comment:2>
Django
"Save as new"
Reporter: giuliettamasina | Owner:
| giuliettamasina
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aschn):
* stage: Unreviewed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/26450#comment:3>
Django
"Save as new"
Reporter: giuliettamasina | Owner:
| giuliettamasina
Component: Documentation | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"23aa700b788e073e6efc4585425c0bd6d3092569" 23aa700]:
{{{
#!CommitTicketReference repository=""
revision="23aa700b788e073e6efc4585425c0bd6d3092569"
Fixed #26450 -- Corrected "Save as new" button label in docs.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26450#comment:4>
Django
"Save as new"
Reporter: giuliettamasina | Owner:
| giuliettamasina
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"dd1ab1499077dcf176b01ae466c262d63fe1d34e" dd1ab149]:
{{{
#!CommitTicketReference repository=""
revision="dd1ab1499077dcf176b01ae466c262d63fe1d34e"
[1.9.x] Fixed #26450 -- Corrected "Save as new" button label in docs.
Backport of 23aa700b788e073e6efc4585425c0bd6d3092569 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26450#comment:5>