[Django] #29506: Misleading migrate "App 'apps.somethings' does not have migrations." error message with nested apps
Django
message with nested apps
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Type: Bug | Status: new
Component: Core | Version: master
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
If you have a couple of nested apps, or apps that are not available
directly in the top-level namespace and you use migrate command, and pass
the full dotted path to this command, the error message is somewhat
misleading:
{{{
CommandError: App 'apps.somethings' does not have migrations.
}}}
In this case, the somethings app have migrations, but migrate command
expecting just app_label.
And there is the other misleading error message.
If you use migrate command and pass nonexistent app in your INSTALLED_APP,
the error message is somewhat misleading:
{{{
CommandError: App 'nonexistent_app' does not have migrations.
}}}
In this case, the nonexistent_app does not exist, but the error message
make user think that nonexistent app just don't have migrations.
Currently, makemigrations command check for existence and validity of app.
As follows
{{{
# Make sure the app they asked for exists
app_labels = set(app_labels)
bad_app_labels = set()
for app_label in app_labels:
try:
apps.get_app_config(app_label)
except LookupError:
bad_app_labels.add(app_label)
if bad_app_labels:
for app_label in bad_app_labels:
if '.' in app_label:
self.stderr.write(
"'%s' is not a valid app label. Did you mean
'%s'?" % (
app_label,
app_label.split('.')[-1],
)
)
else:
self.stderr.write("App '%s' could not be found. Is it
in INSTALLED_APPS?" % app_label)
sys.exit(2)
}}}
How about checking that in migrate command?
== This ticket is very similar to
https://code.djangoproject.com/ticket/29469.
But it is about migrate not makemigrations.
Please read this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/29506>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
message with nested apps
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by oliver):
https://github.com/django/django/pull/10061
--
Ticket URL: <https://code.djangoproject.com/ticket/29506#comment:1>
Django
message with nested apps
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
New description:
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29506#comment:2>
Django
message with nested apps
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
Thanks for the report and the proposed patch. I'll suggest a slightly
different approach in an upcoming patch, as I think the fix for #29469 was
not optimal either.
--
Ticket URL: <https://code.djangoproject.com/ticket/29506#comment:3>
Django
message with nested apps
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
Comment:
My suggested [https://github.com/django/django/pull/10063 PR].
--
Ticket URL: <https://code.djangoproject.com/ticket/29506#comment:4>
Django
message with nested apps
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"c723a1ff8e76aaef227d5af7a57006cc9bfd2fc8" c723a1ff]:
{{{
#!CommitTicketReference repository=""
revision="c723a1ff8e76aaef227d5af7a57006cc9bfd2fc8"
Fixed #29506 -- Added validation for migrate's app_label option.
Thanks MyungSeKyo for the report and the initial patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29506#comment:5>
Django
message with nested apps
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"fc266151648da8856dc735058375ed6cc0e636b5" fc266151]:
{{{
#!CommitTicketReference repository=""
revision="fc266151648da8856dc735058375ed6cc0e636b5"
Refs #29506 -- Added validation for squashmigrations' app_label option.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29506#comment:6>
Django
message with nested apps
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by oliver):
Thank you too.
I learned a lot from your code!
Replying to [comment:5 Tim Graham <timograham@…>]:
> In [changeset:"c723a1ff8e76aaef227d5af7a57006cc9bfd2fc8" c723a1ff]:
> {{{
> #!CommitTicketReference repository=""
revision="c723a1ff8e76aaef227d5af7a57006cc9bfd2fc8"
> Fixed #29506 -- Added validation for migrate's app_label option.
>
> Thanks MyungSeKyo for the report and the initial patch.
> }}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29506#comment:7>