[Django] #35849: ParallelTestSuite reports error occurred in arbitrary test instead of setUpClass

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Type: Bug
Status: new | Component: Testing
| framework
Version: 5.0 | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
When running tests in parallel, if an error occurs in a test suite
(`TestCase`) before the first test method runs, for example in
`setUpClass`, then the shell output incorrectly states that the error
occurred in an arbitrary test method, rather than, for example,
`setUpClass`.

This is a problem because a user reading the test output may not notice
the real error location (for example, `setUpClass`) in the traceback and
may not run the other tests in the test suite.

This is especially problematic if automation parses the error location to
automatically re-run tests (to address flaky, intermittently failing
tests), because the other tests in the suite may never be run.

Repro:

1. Create a Django project for testing:

Instructions to create the project yourself are below. **Or you can use
this existing project** in the `bugdemo/` directory at
https://github.com/dcki/django/blob/demo_report_test_error_bug/bugdemo/README.md

To create the project yourself:

A. Install Python.
B. Create a virtualenv and activate it: `mkdir my_project && cd my_project
&& python3 -m venv .venv && . .venv/bin/activate`
C. Install Django and create a Django project: `pip install django &&
django-admin startproject mysite .`
D. Create a tests directory and an `__init__.py` file inside: `mkdir
mysite/tests && touch mysite/tests/__init__.py`
E. Install tblib: `pip install tblib`
F. Add these tests to the project:

`mysite/tests/test_things.py`

{{{
from django.test import SimpleTestCase


class AlwaysFailTest(SimpleTestCase):
@classmethod
def setUpClass(cls) -> None:
super().setUpClass()
try:
raise Exception('Intentional error')
except:
super().tearDownClass()
raise

def test_should_pass_a(self) -> None:
pass

def test_should_pass_b(self) -> None:
pass


# Exists so that, when an attempt is made to run tests in parallel, and at
# least two TestCases are specified, then tests actually run in parallel.
# (As of this writing, Django runs tests serially if there is only one
test
# suite to run, even if `--parallel=2` is specified.)
class AlwaysPassTest(SimpleTestCase):
def test_should_pass_a(self) -> None:
pass

def test_should_pass_b(self) -> None:
pass
}}}

2. Run the tests: `python3 manage.py test --parallel=2`

Expected output:

{{{
Found 4 test(s).
System check identified no issues (0 silenced).
E..
======================================================================
ERROR: setUpClass (mysite.tests.test_things.AlwaysFailTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dwiniecki/.pyenv/versions/3.11.9/lib/python3.11/unittest/suite.py",
line 166, in _handleClassSetUp
setUpClass()
File "/Users/dwiniecki/src/other/dcki-
django/bugdemo2/mysite/tests/test_things.py", line 9, in setUpClass
raise Exception('Intentional error')
^^^^^^^^^^^^^^^^^
Exception: Intentional error

----------------------------------------------------------------------
Ran 2 tests in 0.214s

FAILED (errors=1)
}}}

Actual output:

{{{
Found 4 test(s).
System check identified no issues (0 silenced).
E..
======================================================================
ERROR: test_should_pass_b
(mysite.tests.test_things.AlwaysFailTest.test_should_pass_b)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dwiniecki/.pyenv/versions/3.11.9/lib/python3.11/unittest/suite.py",
line 166, in _handleClassSetUp
setUpClass()
File "/Users/dwiniecki/src/other/dcki-
django/bugdemo/mysite/tests/test_things.py", line 9, in setUpClass
raise Exception('Intentional error')
^^^^^^^^^^^^^^^^^
Exception: Intentional error

----------------------------------------------------------------------
Ran 2 tests in 0.221s

FAILED (errors=1)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35849>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass

-----------------------------------+--------------------------------------
Reporter: David Winiecki | Owner: (none)

Type: Bug | Status: new
Component: Testing framework | Version: 5.0

Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-----------------------------------+--------------------------------------
Comment (by David Winiecki):

I wrote a proposed fix and regression test for this bug in a fork of the
django GitHub project:

https://github.com/dcki/django/tree/fix_report_test_error

I want to help fix this but I'm not certain what the next step is. I read
all the contributing documentation I could find.

`tox` passes. (Except `tox -e docs` due to a problem with `pyenchant` on
my specific computer, but `pip install pyenchant==3.30rc1 && cd docs &&
make spelling` passes.)
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:1>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-----------------------------------+--------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Bug | Status: new
Component: Testing framework | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Comment (by David Winiecki):

Some of this work was done personally and some of it was done for my
employer https://www.techsmart.codes/

We don't believe we've submitted a "Corporate Contributor License
Agreement" and I haven't submitted an "Individual Contributor License
Agreement". Another team member at TechSmart intends to submit a CCLA in a
few days or so.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:2>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-----------------------------------+--------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Bug | Status: new
Component: Testing framework | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------

Changes (by David Winiecki):

* cc: David Winiecki (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:3>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-----------------------------------+--------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Bug | Status: new
Component: Testing framework | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------

Comment (by David Winiecki):

I think this bug has existed since ParallelTestSuite was first written.
I've confirmed that it exists at least as far back as 4.2. (But personally
I don't feel like it's important enough to backport to earlier versions of
Django.)

As far as I've seen there is no related documentation to update.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:4>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-----------------------------------+--------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Bug | Status: new
Component: Testing framework | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Comment (by David Winiecki):

I'm tempted to check the "has patch" box but I'm not sure if it's too
early to do that. :)
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:5>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass

--------------------------------------+------------------------------------

Reporter: David Winiecki | Owner: (none)

Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* cc: Adam Johnson, Jacob Walls (added)
* stage: Unreviewed => Accepted
* type: Bug => Cleanup/optimization
* version: 5.0 => dev

Comment:

Hello David, thank you for your detailed report. I have reproduced the
issue as you indicated.

I find the distinction between this being an issue or not somewhat
ambiguous. In my view, the first test run "is" the one that fails... but
what leads me to accept this ticket is the fact that the error reporting
differs depending on whether `parallel=1` is set or not.

I will include a few folks in the ticket to see what they recommend, I
took an initial look at your PR but I think we need more expert eyes on
it.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:6>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
--------------------------------------+------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by David Winiecki):

Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:7>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
--------------------------------------+------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by David Winiecki):

I created [a pull request **from the fork to itself** (not to
upstream)](https://github.com/dcki/django/pull/1), just to have a place
for discussion in the context of code. If this is not useful then I'll
close the pull request. I may delete this fork later so if having
historical context is important, then maybe using this pull request is not
a good idea.

My impression is that I shouldn't create a PR to upstream until the
proposed git branch is almost ready to merge, but maybe that's not true.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:8>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
--------------------------------------+------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Jacob Walls):

It makes sense to me to clean up the discrepancy between `parallel=1` and
`parallel=n`, if we can do it easily enough. The single process runner
uses `TextTestRunner`, but the parallel one does not, so it makes sense
that it's "on us" to mimic what `TextTestRunner` does to get consistent
test labels in this edge case. We might want to ensure ''unexpected
success'' is covered just like test errors.

> My impression is that I shouldn't create a PR to upstream until the
proposed git branch is almost ready to merge, but maybe that's not true.

Appreciate you being careful, but I think it's totally appropriate to open
a PR against upstream once the ticket's been accepted.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:9>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
--------------------------------------+------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by David Winiecki):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:10>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
--------------------------------------+------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by David Winiecki):

Okay awesome! I opened a real PR to upstream:
https://github.com/django/django/pull/18695

> We might want to ensure unexpected success is covered just like test
errors.

I think I have an idea what you mean. If you have a chance to elaborate
please do. I'll try to do more here soon.

Thank you all!
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:11>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
--------------------------------------+------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Jacob Walls):

Sure, I just was musing that since unexpected successes are a flavor of
error, we will want to be sure that their reporting doesn't change--since
we still want failures to be labeled with the test name, not anything else
--but that seems unlikely to have changed by your patch, so no worries.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:12>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
--------------------------------------+------------------------------------
Reporter: David Winiecki | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by David Winiecki):

I filled in the "branch description" section in the PR description.

> but that seems unlikely to have changed by your patch

I think I understand. I'll try to learn more soon about unexpected
successes and how they might apply to this.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:13>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass

-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned

Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* owner: (none) => David Winiecki
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:14>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by David Winiecki):

Regarding unexpected successes: It looks to me like
`unittest.TestCase.run()` is the only thing that calls
`result.addUnexpectedSuccess()`, and when I read the definition of
`run()`, it looks to me like it should not interact with the change
proposed in the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:15>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by David Winiecki):

I'm not aware of any open questions currently, so I think it's ready for
review when someone has time.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:16>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Natalia Bidart):

Thank you David, a reviewer will review it soon, but please note that
Django moves at a slow pace, so it may be weeks.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:17>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by David Winiecki):

Thank you Natalia, sounds good.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:18>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:19>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Winiecki):

* needs_better_patch: 1 => 0

Comment:

I think I responded to all current comments in the
[https://github.com/django/django/pull/18695 pull request] and applied
changes where decisions were made, so I don't have other changes pending
currently. I can make more changes when we make more decisions.

I'm unchecking "patch needs improvement" for now. Please let me know if I
shouldn't do that.

Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:20>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:21>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Winiecki):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:22>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:23>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki

Cleanup/optimization | Status: closed

Component: Testing framework | Version: dev

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"661dfdd59809f4abd5077f7a2529735d07b98ba4" 661dfdd]:
{{{#!CommitTicketReference repository=""
revision="661dfdd59809f4abd5077f7a2529735d07b98ba4"
Fixed #35849 -- Made ParallelTestSuite report correct error location.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:25>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki

Cleanup/optimization | Status: assigned

Component: Testing framework | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"41da8a4f5a55c11fb28d2a172a7ad2cff53ca9ec" 41da8a4]:
{{{#!CommitTicketReference repository=""
revision="41da8a4f5a55c11fb28d2a172a7ad2cff53ca9ec"
Refs #35849 -- Added a handle_event hook to ParallelTestSuite.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:24>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki

Cleanup/optimization | Status: closed

Component: Testing framework | Version: dev

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by David Winiecki):

Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:26>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: closed
Component: Testing framework | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Winiecki):

* stage: Ready for checkin => Accepted

Comment:

My manager told me that he submitted a "Corporate Contributor License
Agreement" Monday November 4th.
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:27>

[Django]

#35849: ParallelTestSuite reports error occurred in arbitrary test instead of
setUpClass
-------------------------------------+-------------------------------------
Reporter: David Winiecki | Owner: David
Type: | Winiecki
Cleanup/optimization | Status: closed
Component: Testing framework | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"398cec434bc9359529fea141d22742d71ed25d41" 398cec4]:
{{{#!CommitTicketReference repository=""
revision="398cec434bc9359529fea141d22742d71ed25d41"
Refs #35849 -- Skipped
ParallelTestSuiteTest.test_handle_add_error_before_first_test() without
tblib.

Follow up to 661dfdd59809f4abd5077f7a2529735d07b98ba4.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35849#comment:28>