[Django] #23142: Allow nested comment tags

5 views
Skip to first unread message

Django

unread,
Aug 1, 2014, 5:32:59 AM8/1/14
to django-...@googlegroups.com
#23142: Allow nested comment tags
---------------------------------+---------------------------
Reporter: bcurtu | Owner: nobody
Type: New feature | Status: new
Component: Template system | Version: master
Severity: Normal | Keywords: template tags
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
---------------------------------+---------------------------
It may be usefull to be able to nest {% comment %} tags

--
Ticket URL: <https://code.djangoproject.com/ticket/23142>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 1, 2014, 7:17:07 AM8/1/14
to django-...@googlegroups.com
#23142: Allow nested comment tags
---------------------------------+--------------------------------------

Reporter: bcurtu | Owner: nobody
Type: New feature | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:

Keywords: template tags | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by timo):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

I don't see why it'd be useful. Can you give an example?

--
Ticket URL: <https://code.djangoproject.com/ticket/23142#comment:1>

Django

unread,
Aug 1, 2014, 7:09:02 PM8/1/14
to django-...@googlegroups.com
#23142: Allow nested comment tags
---------------------------------+--------------------------------------

Reporter: bcurtu | Owner: nobody
Type: New feature | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:

Keywords: template tags | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
---------------------------------+--------------------------------------

Comment (by wraus):

I've never tried to nest comment tags, so I'm not sure what would happen,
but I would assume the most common use case is to comment out a block of
code that already contains a commented out block of code, for the purpose
of debugging. I know that I've done that a number of times when I am
working on my Python code, and can see how it would be a pain to work with
for quick "let's see what happens when i comment this out" tests.

--
Ticket URL: <https://code.djangoproject.com/ticket/23142#comment:2>

Django

unread,
Aug 1, 2014, 7:54:07 PM8/1/14
to django-...@googlegroups.com
#23142: Allow nested comment tags
---------------------------------+--------------------------------------

Reporter: bcurtu | Owner: nobody
Type: New feature | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:

Keywords: template tags | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
---------------------------------+--------------------------------------

Comment (by timo):

There are other ways to accomplish that like deleting the code in question
and adding it back using the undo function of your editor. I am not sure
how difficult supporting nested comments would be, but am in favor of
simpler code and believe we have bigger problems to solve. Therefore I'm
in favor of "won't fix".

--
Ticket URL: <https://code.djangoproject.com/ticket/23142#comment:3>

Django

unread,
Aug 2, 2014, 12:11:46 PM8/2/14
to django-...@googlegroups.com
#23142: Allow nested comment tags
---------------------------------+--------------------------------------
Reporter: bcurtu | Owner: nobody
Type: New feature | Status: closed

Component: Template system | Version: master
Severity: Normal | Resolution: wontfix

Keywords: template tags | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by bmispelon):

* status: new => closed
* resolution: => wontfix


Comment:

For another point of reference, the `{% verbatim %}` tag doesn't allow for
nested instances either.

And from what I understand, jinja2 doesn't support them either.

I agree with Tim's arguments and I'm marking this ticket as `wontfix`
consequently. If you want to continue the discussion, try starting a
thread on the `django-developers` mailing list.

Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/23142#comment:4>

Reply all
Reply to author
Forward
0 new messages