[Django] #37181: History view Selenium test uses assertTrue instead of assertEqual

[Django]

#37181: History view Selenium test uses assertTrue instead of assertEqual
-------------------------------------+-------------------------------------
Reporter: Varun | Owner: Varun Kasyap
Kasyap Pentamaraju | Pentamaraju
Type: | Status: assigned
Cleanup/optimization |
Component: | Version: dev
contrib.admin |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
in admin_views.test_history_view.SeleniumTests.test_pagination,

there is an assertion that check last page pagination number.

self.assertTrue(last_page_link.text, "20")

but, seems like it is intended to be assertEqual()

also, setUp creates 1100 records. with admin page size of 100, the last
page should be "11", not "20".
--
Ticket URL: <https://code.djangoproject.com/ticket/37181>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#37181: History view Selenium test uses assertTrue instead of assertEqual
-------------------------------------+-------------------------------------

Reporter: Varun Kasyap | Owner: Varun
Pentamaraju | Kasyap Pentamaraju
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* stage: Unreviewed => Accepted

Comment:

Probably you can make typo fixes like this without a ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/37181#comment:1>

[Django]

#37181: History view Selenium test uses assertTrue instead of assertEqual
-------------------------------------+-------------------------------------
Reporter: Varun Kasyap | Owner: Varun
Pentamaraju | Kasyap Pentamaraju
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Varun Kasyap Pentamaraju):

* has_patch: 0 => 1

Comment:

https://github.com/django/django/pull/21527
--
Ticket URL: <https://code.djangoproject.com/ticket/37181#comment:2>