[Django] #20331: Django admin action cannot serve StreamingHttpResponse
Django
----------------------------------+--------------------
Reporter: Edwin <django@…> | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------
I think it's reasonable enough to have an admin action that serves a
StreamingHttpResponse.
Patch is attached.
--
Ticket URL: <https://code.djangoproject.com/ticket/20331>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Edwin <django@…>):
* needs_better_patch: => 0
* component: Uncategorized => contrib.admin
* needs_tests: => 0
* needs_docs: => 0
* has_patch: 0 => 1
* type: Uncategorized => Bug
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:1>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* needs_docs: 0 => 1
* version: 1.5 => master
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted
Comment:
This is a reasonable request indeed. This needs testing and an entry in
the release note.
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:2>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Comment (by aaugustin):
Yay type checks :-/
The proper solution is to test for `HttpResponseBase` (a private API that
lives in `django.http.response`).
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:3>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:4>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by LukaszBalcerzak):
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
Comment:
Patch looks pretty good
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:5>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
I'm committing this, I'll just remove the line from the release notes
because it's really a bugfix, and we don't mention them all.
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:6>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Hmm, actually six admin_views tests fail under Python 3 with this patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:7>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* cc: timograham@… (added)
* needs_better_patch: 1 => 0
Comment:
Fixed tests and removed release note.
https://github.com/django/django/pull/1230
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:8>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
Comment:
Ran all `admin_views` tests on Python 2.7.3 and 3.2.3 with success,
marking as RFC.
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:9>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"d727518ad61beda4d9c2b744c9c05a805aa23ed1"]:
{{{
#!CommitTicketReference repository=""
revision="d727518ad61beda4d9c2b744c9c05a805aa23ed1"
Fixed #20331 -- Allowed admin actions to serve StreamingHttpResponses
Thanks Edwin.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:10>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by anentropic):
Is there any policy on backporting this fix to older versions...? my
project is on 1.5 and I just hit this bug
I'm happy to do the work if it can get merged quickly
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:11>
Django
Reporter: Edwin <django@…> | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timo):
1.5 is receiving only security fixes at this time. See the
[https://docs.djangoproject.com/en/dev/internals/release-process
/#supported-versions supported versions policy] for details.
--
Ticket URL: <https://code.djangoproject.com/ticket/20331#comment:12>