[Django] #20449: New test runner test fails if run from a different directory
Django
-----------------------------------+--------------------
Reporter: gcc | Owner: nobody
Type: Uncategorized | Status: new
Component: Testing framework | Version: 1.4
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------
{{{
======================================================================
ERROR: test_file_path
(test_runner.test_discover_runner.DiscoverRunnerTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/travis/build/aptivate/django/tests/test_runner/test_discover_runner.py",
line 65, in test_file_path
["test_discovery_sample/"],
File "/home/travis/build/aptivate/django/django/test/runner.py", line 63,
in build_suite
tests = self.test_loader.loadTestsFromName(label)
File "/usr/lib/python2.7/unittest/loader.py", line 91, in
loadTestsFromName
module = __import__('.'.join(parts_copy))
ImportError: Import by filename is not supported.
}}}
<https://next.travis-ci.org/aptivate/django/jobs/7275360>
It seems to be checking if a file exists, using a relative path, in
django/test/runner.py:65:
{{{
if not os.path.exists(label_as_path):
tests = self.test_loader.loadTestsFromName(label)
}}}
And that will behave differently depending if you run your tests from
inside the tests directory like this:
{{{
./runtests.py -v2 --settings=test_postgres_nogis test_runner
}}}
Or from the parent directory, as Travis currently does, like this:
{{{
python -Wall tests/runtests.py --selenium --verbosity 2 \
--settings=django_settings
}}}
I can work around it in Travis by changing working directory before
running the tests, but is it worth fixing this in the test runner, perhaps
using an absolute path based on `__file__`?
Carl Meyer wrote:
I don't think this should be fixed in the test runner itself; in general,
file-path test labels _should_ be interpreted as relative to wherever you
are running the tests from.
But it should be fixed in the
test_runner.test_discover_runner.DiscoverRunnerTest.test_file_path test -
that test apparently needs to isolate itself better by setting the CWD for
the duration of the test, or something similar. Mind filing a bug? I
should be able to take a look soon.
So here it is :)
--
Ticket URL: <https://code.djangoproject.com/ticket/20449>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: gcc | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gcc):
* needs_better_patch: => 0
* version: 1.4 => master
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:1>
Django
Reporter: gcc | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mjtamlyn):
* cc: marc.tamlyn@… (added)
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:2>
Django
Reporter: gcc | Owner: tadeck
Type: Bug | Status: assigned
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by tadeck):
* owner: nobody => tadeck
* status: new => assigned
* type: Uncategorized => Bug
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:3>
Django
Reporter: gcc | Owner: tadeck
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by tadeck):
* cc: tadeck (added)
* status: assigned => closed
* has_patch: 0 => 1
* resolution: => fixed
Comment:
Pull request waiting for review:
https://github.com/django/django/pull/1153
It uses context manager to temporarily change current working directory to
one level up, then switches it back to what it was.
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:4>
Django
Reporter: gcc | Owner: tadeck
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mjtamlyn):
* status: closed => new
* resolution: fixed =>
Comment:
Tickets are closed when the code is merged, not when the pull request is
created.
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:5>
Django
Reporter: gcc | Owner: tadeck
Type: Bug | Status: new
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by tadeck):
Replying to [comment:5 mjtamlyn]:
> Tickets are closed when the code is merged, not when the pull request is
created.
I am sorry, that was not intentional. Missed note on
https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
tickets/#closing-tickets (and marking ticket as fixed resulted in closing
it).
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:6>
Django
Reporter: gcc | Owner: tadeck
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carl Meyer <carl@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"022de7e1393541a3693919e1427d272df89f7f46"]:
{{{
#!CommitTicketReference repository=""
revision="022de7e1393541a3693919e1427d272df89f7f46"
Fixed #20449 - Corrected test sensitivity to current working dir.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:7>
Django
Reporter: gcc | Owner: tadeck
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by nikl@…):
* status: closed => new
* resolution: fixed =>
Comment:
Fixed in: https://github.com/django/django/pull/2657
This also happens to the (newer) {{{test_testcase_ordering()}}} with the
current master:
{{{
tests/runtests.py test_runner
Testing against Django installed in '/home/dev/django/django/django'
Creating test database for alias 'default'...
Creating test database for alias 'other'...
.............E.ss.................
======================================================================
ERROR: test_testcase_ordering
(test_runner.test_discover_runner.DiscoverRunnerTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/dev/django/django/tests/test_runner/test_discover_runner.py", line
107, in test_testcase_ordering
suite = DiscoverRunner().build_suite(["test_discovery_sample/"])
File "/home/dev/django/django/django/test/runner.py", line 66, in
build_suite
tests = self.test_loader.loadTestsFromName(label)
File "/usr/lib/python2.7/unittest/loader.py", line 91, in
loadTestsFromName
module = __import__('.'.join(parts_copy))
ImportError: Import by filename is not supported.
----------------------------------------------------------------------
Ran 34 tests in 1.811s
FAILED (errors=1, skipped=2)
Destroying test database for alias 'default'...
Destroying test database for alias 'other'...
}}}
which can be fixed by applying the already existing {{{with
change_cwd(".."):}}} pattern - maybe this might be moved to {{{setUp()}}}?
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:8>
Django
Reporter: gcc | Owner: tadeck
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mjtamlyn):
* status: new => closed
* resolution: => fixed
Comment:
Fixed in
https://github.com/django/django/commit/d11e83620380fdd98679b09062eefd25f0a98e21
--
Ticket URL: <https://code.djangoproject.com/ticket/20449#comment:9>