[Django] #34857: Date picker cancel button does not respect color theme/dark mode
Django
-----------------------------------------+------------------------
Reporter: Fabian Braun | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
The date picker is styled by admin's `widget.css` which has hard-coded
colours for the date picker's cancel button.
Instead, the CSS variables `--close-button-fg` and `--close-button-bg`
should be used.
--
Ticket URL: <https://code.djangoproject.com/ticket/34857>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Fabian Braun | Owner: Fabian Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Fabian Braun):
* owner: nobody => Fabian Braun
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34857#comment:1>
Django
-------------------------------+----------------------------------------
Reporter: Fabian Braun | Owner: Fabian Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
* cc: Thibaud Colas, Sarah Abderemane, Tom Carrick (added)
* keywords: => accessibility
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/34857#comment:2>
Django
Reporter: Fabian Braun | Owner: Fabian
| Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34857#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
| Braun
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: fixed
Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"34ca1d3ab45f8f3f3d5bb867e4d13ca663deaa89" 34ca1d3]:
{{{
#!CommitTicketReference repository=""
revision="34ca1d3ab45f8f3f3d5bb867e4d13ca663deaa89"
Fixed #34857 -- Made calendar "Cancel" button in admin use color
variables.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34857#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
| Braun
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: fixed
Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"6db8e46e470bb27481c3dc489f8fe687eae7cca6" 6db8e46]:
{{{
#!CommitTicketReference repository=""
revision="6db8e46e470bb27481c3dc489f8fe687eae7cca6"
[5.0.x] Fixed #34857 -- Made calendar "Cancel" button in admin use color
variables.
Backport of 34ca1d3ab45f8f3f3d5bb867e4d13ca663deaa89 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34857#comment:5>