Re: [Django] #13314: "FileField" validation does not account for "upload_to" when counting characters

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
--------------------------------------+------------------------
Reporter: denilsonsa | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Forms
Version: 1.1 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------+------------------------
Changes (by thejaswi_puthraya):

* ui_ux: => 0
* component: Uncategorized => Forms
* easy: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters

----------------------------+-------------------------------------
Reporter: denilsonsa | Owner: nobody
Type: Bug | Status: closed
Component: Forms | Version: 1.1
Severity: Normal | Resolution: duplicate

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

----------------------------+-------------------------------------
Changes (by claudep):

* status: new => closed
* resolution: => duplicate

Comment:

Duplicate of #9893.

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:6>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters

-------------------------------------+-------------------------------------
Reporter: Denilson Figueiredo | Owner: nobody
de Sá |
Type: Bug | Status: new

Component: Forms | Version: 1.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Walter Doekes):

* status: closed => new
* resolution: duplicate =>

Comment:

I've taken the liberty to re-open this, as #9893 never did address this.
See:
https://code.djangoproject.com/ticket/9893#comment:46
https://code.djangoproject.com/ticket/9893#comment:36

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:7>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
-------------------------------------+-------------------------------------
Reporter: Denilson Figueiredo | Owner: nobody
de Sá |
Type: Bug | Status: new
Component: Forms | Version: 1.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Walter Doekes):

* cc: walter+django@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:8>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
-------------------------------------+-------------------------------------
Reporter: Denilson Figueiredo | Owner: nobody
de Sá |
Type: Bug | Status: new
Component: Forms | Version: 1.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Denilson Figueiredo de Sá):

Just an idea… Are we ever going to query the database for the filename? If
not, we could store it as TEXT instead of VARCHAR.

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:9>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
-------------------------------------+-------------------------------------
Reporter: Denilson Figueiredo | Owner: nobody
de Sá |
Type: Bug | Status: new
Component: Forms | Version: 1.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

Changing the datatype to TEXT is likely unacceptable due to backwards
compatibility.

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:10>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
-------------------------------------+-------------------------------------

Reporter: Denilson Figueiredo | Owner: Andrew
de Sá | Northall
Type: Bug | Status: assigned

Component: Forms | Version: 1.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Andrew Northall):

* cc: Andrew Northall (added)
* owner: nobody => Andrew Northall
* has_patch: 0 => 1
* status: new => assigned

Comment:

[https://github.com/django/django/pull/17576 PR]

Implementation details and further comments on GitHub.

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:11>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
-------------------------------------+-------------------------------------
Reporter: Denilson Figueiredo | Owner: Andrew
de Sá | Northall
Type: Bug | Status: assigned
Component: Forms | Version: 1.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

Comment:

Marking as "needs improvement" per
[https://github.com/django/django/pull/17576#issuecomment-1849859524
comment].

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:12>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
-------------------------------------+-------------------------------------
Reporter: Denilson Figueiredo | Owner: Andrew
de Sá | Northall
Type: Bug | Status: assigned
Component: Forms | Version: 1.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Andrew Northall):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:13>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
-------------------------------------+-------------------------------------
Reporter: Denilson Figueiredo | Owner: Andrew
de Sá | Northall
Type: Bug | Status: assigned
Component: Forms | Version: 1.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Bruno Alla):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:14>

[Django]

#13314: "FileField" validation does not account for "upload_to" when counting
characters
-------------------------------------+-------------------------------------
Reporter: Denilson Figueiredo | Owner: Andrew
de Sá | Northall
Type: Bug | Status: assigned
Component: Forms | Version: 1.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

* stage: Ready for checkin => Accepted

Comment:

Marking as "patch needs improvement" as have open questions
--
Ticket URL: <https://code.djangoproject.com/ticket/13314#comment:15>