[Django] #31307: Arrow display error in filter_horizontal field when width less than 1024px

13 views
Skip to first unread message

Django

unread,
Feb 24, 2020, 7:25:08 PM2/24/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-----------------------------------------+--------------------------
Reporter: 007 | Owner: 007
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-----------------------------------------+--------------------------
when screen width less than 1024 filter_horizontal field add and remove
arrow display error when mouth hover

--
Ticket URL: <https://code.djangoproject.com/ticket/31307>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 24, 2020, 7:26:56 PM2/24/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+--------------------------------------

Reporter: 007 | Owner: 007
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by 007):

* Attachment "1.png" added.

Django

unread,
Feb 24, 2020, 7:28:31 PM2/24/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+--------------------------------------

Reporter: 007 | Owner: 007
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by 007):

* Attachment "2.png" added.

Django

unread,
Feb 24, 2020, 7:31:22 PM2/24/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+--------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by 007):

* type: Uncategorized => Bug


--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:1>

Django

unread,
Feb 24, 2020, 8:12:11 PM2/24/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+--------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by 007):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:2>

Django

unread,
Feb 25, 2020, 3:27:01 AM2/25/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted


Old description:

> when screen width less than 1024 filter_horizontal field add and remove
> arrow display error when mouth hover

New description:

when screen width less than 1024 filter_horizontal field add and remove

arrow display error when mouse hover

--

Comment:

Yes, thanks for the report. I'm seeing this only for the Choose arrow, and
not for Remove.

[https://github.com/django/django/pull/12490/files PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:3>

Django

unread,
Feb 25, 2020, 3:46:49 AM2/25/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by 007):

* Attachment "767_1024_hover_remove_current .png" added.

Django

unread,
Feb 25, 2020, 3:47:40 AM2/25/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by 007):

* Attachment "767_1024_hover_remove_expected.png" added.

Django

unread,
Feb 25, 2020, 3:47:58 AM2/25/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by 007):

* Attachment "less_767_hover_remove_current.png" added.

Django

unread,
Feb 25, 2020, 3:48:01 AM2/25/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by 007):

* Attachment "less_767_hover_remove_expected.png" added.

Django

unread,
Feb 25, 2020, 3:54:11 AM2/25/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by 007):

Replying to [comment:3 Carlton Gibson]:


> Yes, thanks for the report. I'm seeing this only for the Choose arrow,
and not for Remove.
>
> [https://github.com/django/django/pull/12490/files PR].

This pr changed `.active.selector-remove:focus, .active.selector-
remove:hover` and `.active.selector-add:focus, .active.selector-add:hover`

--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:4>

Django

unread,
Feb 25, 2020, 4:27:03 AM2/25/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Carlton Gibson):

Thanks for the extra screenshots. Yes, the hover state for the remove
arrow should have the highlight. (I was looking for the misplacement.)

--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:5>

Django

unread,
Feb 25, 2020, 10:22:45 AM2/25/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------+------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Carlton Gibson):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:6>

Django

unread,
Feb 27, 2020, 5:59:31 AM2/27/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------------+-------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:7>

Django

unread,
Feb 27, 2020, 5:59:42 AM2/27/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------------+-------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:8>

Django

unread,
Feb 27, 2020, 9:39:32 AM2/27/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------------+-------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson <carlton@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"a4881f5e5d7ee38b7e83301331a0b4962845ef8a" a4881f5e]:
{{{
#!CommitTicketReference repository=""
revision="a4881f5e5d7ee38b7e83301331a0b4962845ef8a"
Fixed #31307 -- Fixed filter_horizontal add/remove SVG :hover positioning.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:9>

Django

unread,
Feb 27, 2020, 7:11:19 PM2/27/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------------+-------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: closed
Component: contrib.admin | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by 007):

This problem also occurs in 2.2 and 3.0. What do I need to do to merge the
changes into stable/2.2.x and stable/3.0.x

--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:10>

Django

unread,
Feb 28, 2020, 1:40:24 AM2/28/20
to django-...@googlegroups.com
#31307: Arrow display error in filter_horizontal field when width less than 1024px
-------------------------------------+-------------------------------------
Reporter: 007 | Owner: 007
Type: Bug | Status: closed
Component: contrib.admin | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by felixxm):

This patch doesn't qualify for a backport per our backporting policy, see
https://docs.djangoproject.com/en/3.0/internals/release-process/ for more
details.

--
Ticket URL: <https://code.djangoproject.com/ticket/31307#comment:11>

Reply all
Reply to author
Forward
0 new messages