Re: [Django] #6106: make-messages.py should not touch POT-Creation-Date

Django

unread,

Aug 30, 2021, 7:29:05 AM8/30/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Ramiro
Type: | Morales
Cleanup/optimization | Status: closed
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* severity: => Normal
* cc: Daniyal Abbasi (added)
* needs_tests: 0 => 1
* easy: => 0
* ui_ux: => 0
* type: => Cleanup/optimization
* stage: Someday/Maybe => Unreviewed

Comment:

Daniyal, Can you take this to DevelopersMailingList to reach a wider
audience and see what other think? see
[https://code.djangoproject.com/ticket/33056#comment:6 comment].

[https://github.com/django/django/pull/14800 PR]

#33056 was a duplicate.

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Aug 30, 2021, 7:01:36 PM8/30/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Ramiro
Type: | Morales
Cleanup/optimization | Status: closed
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Daniyal Abbasi):

Sure Mariusz. I've started the discussion on the mailing list!
[https://groups.google.com/g/django-developers/c/8QK4MYIE-
Us/m/oNygOdHTAwAJ Link]

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:10>

Django

unread,

Sep 1, 2021, 2:09:14 AM9/1/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Ramiro
Type: | Morales

Cleanup/optimization | Status: new

Component: | Version: dev
Internationalization |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* status: closed => new
* resolution: wontfix =>
* stage: Unreviewed => Accepted

Comment:

Reopening. Discussion in DevelopersMailingList seems to reached a
consensus.

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:11>

Django

unread,

Sep 1, 2021, 2:09:24 AM9/1/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------

Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: assigned

* owner: Ramiro Morales => Daniyal Abbasi
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:12>

Django

unread,

Sep 6, 2021, 8:13:35 AM9/6/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: assigned
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Ad Timmering):

* cc: Ad Timmering (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:13>

Django

unread,

Sep 18, 2021, 5:53:47 PM9/18/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: assigned
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Ad Timmering):

Hi @Daniyal - would love to see this implemented. I think the last request
was to add tests - to which you asked a question (ticket:33056#comment:3)
on where to put them. Do you still have time to work on tests, and/or are
you still waiting for a reply to that?

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:14>

Django

unread,

Sep 20, 2021, 6:24:52 AM9/20/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: assigned
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Daniyal Abbasi):

Hey
Yes I do have the time to work on this. I'm waiting on some guidance on
how I should be incorporating the tests for the same!

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:15>

Django

unread,

Sep 21, 2021, 10:46:37 PM9/21/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: assigned
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Ad Timmering):

Great. I would probably suggest you pick whatever place you think is best
for the tests for now and add them to the PR, so you can remove the "Needs
tests" flag - which will then trigger someone coming in for review. (As
you will have seen the Django team just pushed 4.0.0 alpha 1 so are
probably a bit occupied at the moment).

It looks like the tests in `test_extraction` are broken out quite
granularly over multiple classes, so personally I would probably suggest a
separate test class.

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:16>

Django

unread,

Sep 25, 2021, 7:37:07 AM9/25/21

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Daniyal Abbasi):

* needs_tests: 1 => 0

Comment:

Sure. For now I've added a test in the test_extraction.BasicExtractorTests
class itself.

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:17>

Django

unread,

Sep 28, 2021, 3:03:34 AM9/28/21

to django-...@googlegroups.com

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:18>

Django

unread,

Oct 2, 2021, 3:41:06 AM10/2/21

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Daniyal Abbasi):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:19>

Django

unread,

Oct 13, 2021, 8:15:05 AM10/13/21

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:20>

Django

unread,

Oct 26, 2021, 7:44:21 PM10/26/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: assigned
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Arthur):

* cc: Arthur (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:21>

Django

unread,

Nov 9, 2021, 8:08:15 AM11/9/21

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Ad Timmering):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:22>

Django

unread,

Nov 11, 2021, 4:02:51 AM11/11/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: assigned
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:23>

Django

unread,

Nov 11, 2021, 5:18:23 AM11/11/21

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi

Cleanup/optimization | Status: closed
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution: fixed

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"4bfe8c0eec835b8eaffcda7dc1e3b203751a790a" 4bfe8c0]:
{{{
#!CommitTicketReference repository=""
revision="4bfe8c0eec835b8eaffcda7dc1e3b203751a790a"
Fixed #6106 -- Prevented makemessages from changing .po files when up to
date.

Co-authored-by: Daniyal Abbasi <abbasi.d...@gmail.com>
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:24>

Django

unread,

Mar 6, 2022, 5:04:41 PM3/6/22

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: closed
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Petar Marić):

* cc: Petar Marić (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:25>

Django

unread,

Feb 7, 2023, 9:56:30 AM2/7/23

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: closed
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by אורי):

#34318

--
Ticket URL: <https://code.djangoproject.com/ticket/6106#comment:26>

Django

unread,

Feb 7, 2023, 10:17:53 AM2/7/23

to django-...@googlegroups.com

#6106: make-messages.py should not touch POT-Creation-Date
-------------------------------------+-------------------------------------
Reporter: Marc Fargas | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: closed
Component: | Version: dev
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------