[Django] #33141: Rename Aggregate.empty_aggregate_value to empty_result_set_value
Django
-------------------------------------+-------------------------------------
Reporter: David | Owner: nobody
Wobrock |
Type: | Status: assigned
Cleanup/optimization |
Component: Database | Version: 4.0
layer (models, ORM) | Keywords:
Severity: Normal | empty_aggregate_value,empty_result_set_value,aggregate,orm,empty
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Hi,
In the context of #33018 and
[https://github.com/django/django/pull/14770#pullrequestreview-761591996 a
comment on its PR], a suggestion was made to rename
`Aggregate.empty_aggregate_value` to `empty_result_set_value`
It might even be moved from the `Aggregate` class to `Func` to be more
general, since in #33018 we define this attribute/property for `Coalesce`.
--
Ticket URL: <https://code.djangoproject.com/ticket/33141>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Wobrock
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
empty_aggregate_value,empty_result_set_value,aggregate,orm,empty| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: David Wobrock (added)
* owner: nobody => David Wobrock
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/14894 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33141#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: David Wobrock | Owner: David
Type: | Wobrock
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
empty_aggregate_value,empty_result_set_value,aggregate,orm,empty|
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/33141#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: David Wobrock | Owner: David
Type: | Wobrock
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
empty_aggregate_value,empty_result_set_value,aggregate,orm,empty|
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33141#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: David Wobrock | Owner: David
Type: | Wobrock
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
empty_aggregate_value,empty_result_set_value,aggregate,orm,empty|
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/33141#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: David Wobrock | Owner: David
Type: | Wobrock
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution:
empty_aggregate_value,empty_result_set_value,aggregate,orm,empty| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33141#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: David Wobrock | Owner: David
Type: | Wobrock
Component: Database layer | Version: 4.0
(models, ORM) |
Keywords: | Triage Stage: Ready for
empty_aggregate_value,empty_result_set_value,aggregate,orm,empty| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"ad36a198a12df4dff65992191b3eb0a474e2daac" ad36a198]:
{{{
#!CommitTicketReference repository=""
revision="ad36a198a12df4dff65992191b3eb0a474e2daac"
Fixed #33141 -- Renamed Expression.empty_aggregate_value to
empty_result_set_value.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33141#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: David Wobrock | Owner: David
Type: | Wobrock
Cleanup/optimization | Status: closed
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
empty_aggregate_value,empty_result_set_value,aggregate,orm,empty| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"aab76433ed585ebe997b94547e0d790605e01ad9" aab76433]:
{{{
#!CommitTicketReference repository=""
revision="aab76433ed585ebe997b94547e0d790605e01ad9"
[4.0.x] Fixed #33141 -- Renamed Expression.empty_aggregate_value to
empty_result_set_value.
Backport of ad36a198a12df4dff65992191b3eb0a474e2daac from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33141#comment:7>