[Django] #31359: Deprecate using get_random_string without an explicit length

27 views
Skip to first unread message

Django

unread,
Mar 11, 2020, 4:45:58 AM3/11/20
to django-...@googlegroups.com
#31359: Deprecate using get_random_string without an explicit length
------------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Utilities | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
`django.utils.crypto.get_random_string` currently has a default `length`
value (12). I think we should force callers to specify the length value
and not count on a default.

--
Ticket URL: <https://code.djangoproject.com/ticket/31359>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 11, 2020, 4:50:20 AM3/11/20
to django-...@googlegroups.com
#31359: Deprecate using get_random_string without an explicit length
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/12556 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/31359#comment:1>

Django

unread,
Mar 11, 2020, 6:01:25 AM3/11/20
to django-...@googlegroups.com
#31359: Deprecate using get_random_string without an explicit length
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* owner: nobody => Claude Paroz
* status: new => assigned
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/31359#comment:2>

Django

unread,
Mar 11, 2020, 8:20:49 AM3/11/20
to django-...@googlegroups.com
#31359: Deprecate using get_random_string without an explicit length
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/31359#comment:3>

Django

unread,
Mar 11, 2020, 9:04:45 AM3/11/20
to django-...@googlegroups.com
#31359: Deprecate using get_random_string without an explicit length
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: closed
Component: Utilities | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"e663f695fb282053b31f69ee2dcbc67ddacb9104" e663f69]:
{{{
#!CommitTicketReference repository=""
revision="e663f695fb282053b31f69ee2dcbc67ddacb9104"
Fixed #31359 -- Deprecated get_random_string() calls without an explicit
length.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31359#comment:4>

Django

unread,
Jan 14, 2021, 2:12:18 PM1/14/21
to django-...@googlegroups.com
#31359: Deprecate using get_random_string without an explicit length
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: closed
Component: Utilities | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"be6e46813010f47e3dec22dd8c360df2dcf53369" be6e4681]:
{{{
#!CommitTicketReference repository=""
revision="be6e46813010f47e3dec22dd8c360df2dcf53369"
Refs #31359 -- Made get_random_string()'s length argument required.

Per deprecation timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31359#comment:5>

Reply all
Reply to author
Forward
0 new messages