[Django] #34042: Screen reader issues with admin navigation sidebar

[Django]

#34042: Screen reader issues with admin navigation sidebar
-------------------------------------+-------------------------------------
Reporter: Thibaud | Owner: nobody
Colas |
Type: Bug | Status: new
Component: | Version: 4.0
contrib.admin | Keywords: accessibility,
Severity: Normal | screen reader, landmarks
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
There are three issues with the admin’s toggle-able sidebar nav for screen
reader users:

- Its toggle button doesn’t set `aria-expanded` to indicate its state.
This is important so people can tell whether the current state is "opened"
or "closed".
- The sidebar is wrapped in a `<nav>` landmark (good!) but that landmark
should ideally have a label set with `aria-label="{% translate 'Sidebar'
%}"` so users can more easily decide whether this is the part of the UI
they want to go to.
- The sidebar shouldn’t be navigable when closed (to replicate the
experience of sighted users). This is because we’re preventing navigation
by setting `tabindex="-1"` on the sidebar interactive elements. Instead,
we should set the whole region to `display: none` or `visibility: hidden`
when closed.

--
Ticket URL: <https://code.djangoproject.com/ticket/34042>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34042: Screen reader issues with admin navigation sidebar
-------------------------------------+-------------------------------------

Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/34042#comment:1>

[Django]

#34042: Screen reader issues with admin navigation sidebar
-------------------------------------+-------------------------------------

Reporter: Thibaud Colas | Owner: Gloib
Type: Bug | Status: assigned

Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Gloib):

* owner: nobody => Gloib
* status: new => assigned
* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/16093 patch created here]

--
Ticket URL: <https://code.djangoproject.com/ticket/34042#comment:2>

[Django]

#34042: Screen reader issues with admin navigation sidebar
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Gloib
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34042#comment:3>

[Django]

[Django]

#34042: Screen reader issues with admin navigation sidebar
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Gloib
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:

Keywords: accessibility, | Triage Stage: Ready for
screen reader, landmarks | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34042#comment:4>

[Django]

#34042: Screen reader issues with admin navigation sidebar
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Gloib

Type: Bug | Status: closed
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution: fixed

Keywords: accessibility, | Triage Stage: Ready for
screen reader, landmarks | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"c4aac2ac1e469f0dc27b4dce230c7b29add617ba" c4aac2ac]:
{{{
#!CommitTicketReference repository=""
revision="c4aac2ac1e469f0dc27b4dce230c7b29add617ba"
Fixed #34042 -- Improved accessibility of admin's navigation sidebar.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34042#comment:5>