[Django] #29628: Createsuperuser does not validate password against username or other required fields
Django
required fields
-----------------------------------------+------------------------
Reporter: Josh Schneier | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/29628>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
required fields
Reporter: Josh Schneier | Owner: Josh Schneier
Type: Bug | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Josh Schneier):
* owner: nobody => Josh Schneier
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/29628#comment:1>
Django
required fields
-------------------------------+-----------------------------------------
Reporter: Josh Schneier | Owner: Josh Schneier
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham):
It looks to me like it does (as of
53d28f83390aed98fab4eed187eaf1edaa92c6d0). Is there a bug with the
`fake_user_data` approach?
--
Ticket URL: <https://code.djangoproject.com/ticket/29628#comment:2>
Django
required fields
-------------------------------+-----------------------------------------
Reporter: Josh Schneier | Owner: Josh Schneier
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Josh Schneier):
Username isn’t included in fake user data and the validation runs inside
of the for loop before all fields can be collected. I have failing test
cases I just pushed up in a PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/29628#comment:3>
Django
required fields
-------------------------------+-----------------------------------------
Reporter: Josh Schneier | Owner: Josh Schneier
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/29628#comment:4>
Django
required fields
-------------------------------+-----------------------------------------
Reporter: Josh Schneier | Owner: Josh Schneier
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/10261 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29628#comment:5>
Django
required fields
-------------------------------+-----------------------------------------
Reporter: Josh Schneier | Owner: Josh Schneier
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"793e9bb35af34aa11320866bcc6ad8edaf1480a7" 793e9bb3]:
{{{
#!CommitTicketReference repository=""
revision="793e9bb35af34aa11320866bcc6ad8edaf1480a7"
Fixed #29628 -- Made createsuperuser validate password against username
and required fields.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29628#comment:6>
Django
required fields
-------------------------------+-----------------------------------------
Reporter: Josh Schneier | Owner: Josh Schneier
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by GitHub <noreply@…>):
In [changeset:"da266b3c5ca4bb7581d7a3cc51bc820e78cf64f0" da266b3]:
{{{
#!CommitTicketReference repository=""
revision="da266b3c5ca4bb7581d7a3cc51bc820e78cf64f0"
Refs #29628, Refs #33178 -- Made createsuperuser validate password against
required fields passed in options.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29628#comment:7>
Django
required fields
-------------------------------+-----------------------------------------
Reporter: Josh Schneier | Owner: Josh Schneier
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"224fa0bc7de05f3f269e7fd41b66154b82a2e87f" 224fa0bc]:
{{{
#!CommitTicketReference repository=""
revision="224fa0bc7de05f3f269e7fd41b66154b82a2e87f"
[4.0.x] Refs #29628, Refs #33178 -- Made createsuperuser validate password
against required fields passed in options.
Backport of da266b3c5ca4bb7581d7a3cc51bc820e78cf64f0 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29628#comment:8>