[Django] #27291: Missing attribute: CheckboxSelectMultiple.dont_use_model_field_default_for_empty_data = True

2 views
Skip to first unread message

Django

unread,
Sep 29, 2016, 1:40:09 AM9/29/16
to django-...@googlegroups.com
#27291: Missing attribute:
CheckboxSelectMultiple.dont_use_model_field_default_for_empty_data = True
----------------------------+--------------------
Reporter: stephenmcd | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+--------------------
This commit introduced the `dont_use_model_field_default_for_empty_data`
attribute for controlling whether a widget should use default values when
its not present in the HTTP request, and applied to the `CheckboxInput`
since checkboxes don't send an empty value when unchecked:

https://github.com/django/django/commit/325dd0befea3012c42eefa061f509fbdf1b6a8aa

The issue is that it was overlooked on the CheckboxSelectMultiple widget,
which now uses a default value when all checkboxes are unchecked.

--
Ticket URL: <https://code.djangoproject.com/ticket/27291>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 29, 2016, 1:53:43 AM9/29/16
to django-...@googlegroups.com
#27291: Missing attribute:
CheckboxSelectMultiple.dont_use_model_field_default_for_empty_data = True
----------------------------+--------------------------------------

Reporter: stephenmcd | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
----------------------------+--------------------------------------
Changes (by stephenmcd):

* needs_better_patch: => 0
* has_patch: 0 => 1
* easy: 0 => 1
* needs_tests: => 0
* needs_docs: => 0


Comment:

PR here:

https://github.com/django/django/pull/7312

--
Ticket URL: <https://code.djangoproject.com/ticket/27291#comment:1>

Django

unread,
Sep 29, 2016, 11:34:22 AM9/29/16
to django-...@googlegroups.com
#27291: Missing attribute:
CheckboxSelectMultiple.dont_use_model_field_default_for_empty_data = True
----------------------------+--------------------------------------
Reporter: stephenmcd | Owner: nobody
Type: Bug | Status: closed
Component: Forms | Version: 1.10
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
----------------------------+--------------------------------------
Changes (by Tim Graham):

* status: new => closed
* resolution: => duplicate


Comment:

I'll reopen #27186.

--
Ticket URL: <https://code.djangoproject.com/ticket/27291#comment:2>

Reply all
Reply to author
Forward
0 new messages