[Django] #31939: Allow to specify a custom --add-comments option to pass to xgettext in makemessages command

15 views
Skip to first unread message

Django

unread,
Aug 24, 2020, 1:37:36 PM8/24/20
to django-...@googlegroups.com
#31939: Allow to specify a custom --add-comments option to pass to xgettext in
makemessages command
-------------------------------------+-------------------------------------
Reporter: Álvaro | Owner: nobody
Mondéjar |
Type: New | Status: new
feature |
Component: Core | Version: master
(Management commands) |
Severity: Normal | Keywords: i18n
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
Django programs that use any other language as source instead of english
might find this useful.

We can use '--add-comments', '-c' as arguments of the makemessages command
parser to maintain consistence with xgettext.

--
Ticket URL: <https://code.djangoproject.com/ticket/31939>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 24, 2020, 1:38:26 PM8/24/20
to django-...@googlegroups.com
#31939: Allow to specify a custom --add-comments option to pass to xgettext in
makemessages command
-------------------------------------+-------------------------------------
Reporter: Álvaro Mondéjar | Owner: nobody
Type: New feature | Status: new
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: i18n | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Álvaro Mondéjar):

* needs_docs: 0 => 1
* needs_tests: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31939#comment:1>

Django

unread,
Aug 24, 2020, 3:13:14 PM8/24/20
to django-...@googlegroups.com
#31939: Allow to specify a custom --add-comments option to pass to xgettext in
makemessages.

-------------------------------------+-------------------------------------
Reporter: Álvaro Mondéjar | Owner: nobody
Type: New feature | Status: closed
Component: | Version: master
Internationalization |
Severity: Normal | Resolution: wontfix

Keywords: i18n | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* status: new => closed
* cc: Claude Paroz (added)
* component: Core (Management commands) => Internationalization
* needs_tests: 1 => 0
* needs_docs: 1 => 0
* resolution: => wontfix


Comment:

Thanks for this ticket, however comments for translators are already
supported (see
[https://docs.djangoproject.com/en/3.1/topics/i18n/translation/#comments-
for-translators docs]). Making an extraction keyword configurable was
discussed shortly in the #10004 (see
[https://code.djangoproject.com/ticket/10004#comment:12 comment]) and
we've decided that this isn't worth adding extra complexity.

--
Ticket URL: <https://code.djangoproject.com/ticket/31939#comment:2>

Django

unread,
Aug 25, 2020, 2:26:15 AM8/25/20
to django-...@googlegroups.com
#31939: Allow to specify a custom --add-comments option to pass to xgettext in
makemessages.
-------------------------------------+-------------------------------------
Reporter: Álvaro Mondéjar | Owner: nobody
Type: New feature | Status: closed
Component: | Version: master
Internationalization |
Severity: Normal | Resolution: wontfix
Keywords: i18n | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

Note you should be able to customize this rather easily by having your own
`makemessages` command in your project (inheriting the original command
and overwriting `xgettext_options`).

--
Ticket URL: <https://code.djangoproject.com/ticket/31939#comment:3>

Reply all
Reply to author
Forward
0 new messages