[Django] #29089: Duplicate date parsing in `SelectDateWidget.format_value()`

[Django]

#29089: Duplicate date parsing in `SelectDateWidget.format_value()`
------------------------------------------+------------------------
Reporter: Carlton Gibson | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
`SelectDateWidget.format_value()` contains a block to parse a string value
into year, month and day components.

The current implementation first attempts to parse `value` as a
`datetime`.

Regardless of the outcome here it then parses `value` again against
against a regex.

Current implementation:

https://github.com/django/django/blob/d4bbd3f41882104156cf9f2b02cb13376a59489d/django/forms/widgets.py#L1006-L1018

{{{
elif isinstance(value, str):
if settings.USE_L10N:
input_format = get_format('DATE_INPUT_FORMATS')[0]
try:
d = datetime.datetime.strptime(value, input_format)
except ValueError:
pass
else:
year, month, day = d.year, d.month, d.day
match = self.date_re.match(value)
if match:
year, month, day = [int(val) for val in match.groups()]
return {'year': year, 'month': month, 'day': day}
}}}

With default settings `input_format` is (essentially) the same as the
`date_re`. We end up doing the work twice.

Should we not skip the `re.match` block if the `strptime` approach already
succeeded?

--
Ticket URL: <https://code.djangoproject.com/ticket/29089>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#29089: Redundant date parsing in SelectDateWidget.format_value()
--------------------------------+------------------------------------

Reporter: Carlton Gibson | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------+------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1
* stage: Unreviewed => Accepted

Comment:

[https://github.com/django/django/pull/9638 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/29089#comment:1>

[Django]

#29089: Redundant date parsing in SelectDateWidget.format_value()

-------------------------------------+-------------------------------------

Reporter: Carlton Gibson | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by felixxm):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/29089#comment:2>

[Django]

#29089: Redundant date parsing in SelectDateWidget.format_value()
-------------------------------------+-------------------------------------

Reporter: Carlton Gibson | Owner: nobody

Type: Bug | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"5538729e4ec1adf1c79d94c2b47b5dcf591ad94b" 5538729e]:
{{{
#!CommitTicketReference repository=""
revision="5538729e4ec1adf1c79d94c2b47b5dcf591ad94b"
Fixed #29089 -- Avoided redundant date parsing in
SelectDateWidget.format_value().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29089#comment:3>