[Django] #28009: Changes to models.CharField and forms.CharField impact subclasses as well

[Django]

#28009: Changes to models.CharField and forms.CharField impact subclasses as well
-------------------------------------+-------------------------------------
Reporter: Matt | Owner: Matt Braymer-Hayes
Braymer-Hayes |
Type: | Status: assigned
Cleanup/optimization |
Component: | Version: 1.11
Documentation |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Hi folks, question: Do the changes made in #4136 also impact
`models.CharField` subclasses (`CommaSeparatedIntegerField`, `EmailField`,
`SlugField`, and `URLField`) and `forms.CharField` subclasses
(`RegexField`, `EmailField`, `URLField`, `GenericIPAddressField`,
`SlugField`, and `UUIDField`)? Based on my review of the code they do,
though I may be missing something. If they are, the docstrings and
documentation for each of the `forms.CharField` subclasses should be
updated. Additionally, the release notes should mention the other fields
impacted. I'm happy to make a PR, if this is the case.

--
Ticket URL: <https://code.djangoproject.com/ticket/28009>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#28009: Document and test Field.empty_value for CharField subclasses
-------------------------------------+-------------------------------------
Reporter: Matt Braymer-Hayes | Owner: Matt
Type: | Braymer-Hayes
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/28009#comment:1>

[Django]

#28009: Document and test Field.empty_value for CharField subclasses
-------------------------------------+-------------------------------------
Reporter: Matt Braymer-Hayes | Owner: Matt
Type: | Braymer-Hayes
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Daniel Greenfeld):

Looking at the source code
(https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L2237)
shows that the new CharField behavior is the same for other fields
inheriting from it.

--
Ticket URL: <https://code.djangoproject.com/ticket/28009#comment:2>

[Django]

#28009: Document and test Field.empty_value for CharField subclasses

--------------------------------------+------------------------------------
Reporter: Matt Braymer-Hayes | Owner: (none)
Type: Cleanup/optimization | Status: new

Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Matt Braymer-Hayes):

* status: assigned => new
* owner: Matt Braymer-Hayes => (none)

--
Ticket URL: <https://code.djangoproject.com/ticket/28009#comment:3>

[Django]

#28009: Document and test Field.empty_value for CharField subclasses

-------------------------------------+-------------------------------------
Reporter: Matt Braymer-Hayes | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned

Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Srinivas Reddy Thatiparthy):

* owner: (none) => Srinivas Reddy Thatiparthy
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/28009#comment:4>

[Django]

#28009: Document and test Field.empty_value for CharField subclasses
-------------------------------------+-------------------------------------

Reporter: Matt Braymer-Hayes | Owner: David
Type: | Smith

Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Smith):

* owner: Srinivas Reddy Thatiparthy => David Smith
* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/28009#comment:5>

[Django]

#28009: Document and test Field.empty_value for CharField subclasses
-------------------------------------+-------------------------------------
Reporter: Matt Braymer-Hayes | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Smith):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/28009#comment:6>

[Django]

#28009: Document and test Field.empty_value for CharField subclasses
-------------------------------------+-------------------------------------
Reporter: Matt Braymer-Hayes | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Smith):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/28009#comment:7>

[Django]

#28009: Document and test Field.empty_value for CharField subclasses
-------------------------------------+-------------------------------------
Reporter: Matt Braymer-Hayes | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.11
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* status: new => assigned

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/28009#comment:8>