Re: [Django] #14300: manage.py sqlcustom fails if models are in a submodule

[Django]

#14300: manage.py sqlcustom fails if models are in a submodule
-------------------------------------+-------------------------------------
Reporter: al_the_x | Owner: fheinz
Type: Bug | Status: reopened
Component: Core (Management | Version: 1.2
commands) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by emyller):

* cc: emyller@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/14300#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#14300: manage.py sqlcustom fails if models are in a submodule
-------------------------------------+-------------------------------------
Reporter: al_the_x | Owner: fheinz
Type: Bug | Status: reopened
Component: Core (Management | Version: 1.2
commands) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by claudep):

#19338 and #19358 are duplicates.

--
Ticket URL: <https://code.djangoproject.com/ticket/14300#comment:8>

[Django]

#14300: manage.py sqlcustom fails if models are in a submodule
-------------------------------------+-------------------------------------
Reporter: al_the_x | Owner: fheinz

Type: Bug | Status: new

Component: Core (Management | Version: 1.2
commands) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0

Has patch: 1 | Patch needs improvement: 0

Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by timo):

* cc: timograham@… (added)
* needs_better_patch: 1 => 0

Comment:

https://github.com/django/django/pull/1359

--
Ticket URL: <https://code.djangoproject.com/ticket/14300#comment:10>

[Django]

#14300: manage.py sqlcustom fails if models are in a submodule
-------------------------------------+-------------------------------------
Reporter: al_the_x | Owner: fheinz
Type: Bug | Status: new
Component: Core (Management | Version: 1.2
commands) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by timo):

Also reported in #15519 the [https://github.com/django/django/pull/747 PR]
there addresses backwards incompatibility by searching both `app/sql` and
`app/models/sql` with a `DeprecationWarning` if the latter is used. I'm
not a huge fan of adding extra code and tests to support that for a
release or two, but I'll do it if necessary.

--
Ticket URL: <https://code.djangoproject.com/ticket/14300#comment:11>

[Django]

#14300: manage.py sqlcustom fails if models are in a submodule
-------------------------------------+-------------------------------------
Reporter: al_the_x | Owner: fheinz
Type: Bug | Status: new
Component: Core (Management | Version: 1.2
commands) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by vzima):

* cc: vlastimil@… (added)

Comment:

Replying to [comment:11 timo]:

> Also reported in #15519 the [https://github.com/django/django/pull/747
PR] there addresses backwards incompatibility by searching both `app/sql`
and `app/models/sql` with a `DeprecationWarning` if the latter is used.
I'm not a huge fan of adding extra code and tests to support that for a
release or two, but I'll do it if necessary.

In #15519:comment:2 jacob required to use both locations. My patch also
contains a test. The patch does not apply, because of all the changes in
tests, but it should be easy to fix.

--
Ticket URL: <https://code.djangoproject.com/ticket/14300#comment:12>

[Django]

#14300: manage.py sqlcustom fails if models are in a submodule
-------------------------------------+-------------------------------------
Reporter: al_the_x | Owner: fheinz

Type: Bug | Status: closed

Component: Core (Management | Version: 1.2

commands) | Resolution: fixed

Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"31c13a99bb9ebdaf12ccab4e880c5da930d86e79"]:
{{{
#!CommitTicketReference repository=""
revision="31c13a99bb9ebdaf12ccab4e880c5da930d86e79"
Fixed #14300 -- Fixed initial SQL location if models is a package.

Thanks al_the_x for the report and fheinz for the draft patch.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/14300#comment:13>