[Django] #31030: register SQLite functions as deterministic on Python 3.8

25 views
Skip to first unread message

Django

unread,
Nov 25, 2019, 7:58:07 AM11/25/19
to django-...@googlegroups.com
#31030: register SQLite functions as deterministic on Python 3.8
-------------------------------------+-------------------------------------
Reporter: Sergey | Owner: nobody
Fedoseev |
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords: sqlite
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
On Python 3.8 `deterministic` parameter was added to
[https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.create_function
sqlite3.Connection.create_function() ], it should be used when possible to
allow SQLite to perform additional optimizations.

--
Ticket URL: <https://code.djangoproject.com/ticket/31030>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 25, 2019, 9:53:03 AM11/25/19
to django-...@googlegroups.com
#31030: register SQLite functions as deterministic on Python 3.8
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: sqlite | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* stage: Unreviewed => Accepted


Comment:

We'll want to makes to not do so for function using global or connection
state (e.g. timezone).

--
Ticket URL: <https://code.djangoproject.com/ticket/31030#comment:1>

Django

unread,
Nov 26, 2019, 3:15:16 AM11/26/19
to django-...@googlegroups.com
#31030: register SQLite functions as deterministic on Python 3.8
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: sqlite | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sergey Fedoseev):

[https://github.com/django/django/pull/12145 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/31030#comment:2>

Django

unread,
Nov 26, 2019, 3:15:37 AM11/26/19
to django-...@googlegroups.com
#31030: register SQLite functions as deterministic on Python 3.8
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: sqlite | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sergey Fedoseev):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31030#comment:3>

Django

unread,
Dec 3, 2019, 8:05:40 AM12/3/19
to django-...@googlegroups.com
#31030: register SQLite functions as deterministic on Python 3.8
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: sqlite | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* status: new => assigned
* needs_docs: 0 => 1
* owner: nobody => Sergey Fedoseev


--
Ticket URL: <https://code.djangoproject.com/ticket/31030#comment:4>

Django

unread,
Apr 6, 2020, 4:29:07 AM4/6/20
to django-...@googlegroups.com
#31030: register SQLite functions as deterministic on Python 3.8
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: sqlite | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* needs_docs: 1 => 0


Comment:

[https://github.com/django/django/pull/12668 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/31030#comment:5>

Django

unread,
Apr 6, 2020, 6:03:03 AM4/6/20
to django-...@googlegroups.com
#31030: register SQLite functions as deterministic on Python 3.8
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: closed

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: sqlite | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"026719cf17ae2b088f7553321f2ca6b45efa8cb4" 026719cf]:
{{{
#!CommitTicketReference repository=""
revision="026719cf17ae2b088f7553321f2ca6b45efa8cb4"
Fixed #31030 -- Registered SQLite functions as deterministic on Python
3.8+.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31030#comment:6>

Reply all
Reply to author
Forward
0 new messages