Re: [Django] #34982: Visual regression for helptext at certain screen sizes

22 views
Skip to first unread message

Django

unread,
Nov 23, 2023, 12:32:30 PM11/23/23
to django-...@googlegroups.com
#34982: Visual regression for helptext at certain screen sizes
----------------------------------+---------------------------------------
Reporter: Mariusz Felisiak | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+---------------------------------------
Changes (by Tom Carrick):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/17518 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34982#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 23, 2023, 3:37:11 PM11/23/23
to django-...@googlegroups.com
#34982: Visual regression for helptext at certain screen sizes
----------------------------------+---------------------------------------
Reporter: Mariusz Felisiak | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+---------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/34982#comment:7>

Django

unread,
Nov 27, 2023, 10:40:28 AM11/27/23
to django-...@googlegroups.com
#34982: Visual regression for helptext at certain screen sizes
-------------------------------------+-------------------------------------

Reporter: Mariusz Felisiak | Owner: Tom
| Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34982#comment:8>

Django

unread,
Nov 27, 2023, 1:19:57 PM11/27/23
to django-...@googlegroups.com
#34982: Visual regression for helptext at certain screen sizes
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia <124304+nessita@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"729266c6f29c7a0677b24926a86a767ef3078b26" 729266c6]:
{{{
#!CommitTicketReference repository=""
revision="729266c6f29c7a0677b24926a86a767ef3078b26"
Fixed #34982 -- Fixed admin's read-only password widget and help texts
alignment for tablet screen size.

Co-authored-by: Sarah Boyce <42296566+...@users.noreply.github.com>
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34982#comment:9>

Django

unread,
Nov 27, 2023, 1:20:53 PM11/27/23
to django-...@googlegroups.com
#34982: Visual regression for helptext at certain screen sizes
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"432bfa26151f1330dddf1635358a3b60a5947b9f" 432bfa26]:
{{{
#!CommitTicketReference repository=""
revision="432bfa26151f1330dddf1635358a3b60a5947b9f"
[5.0.x] Fixed #34982 -- Fixed admin's read-only password widget and help


texts alignment for tablet screen size.

Co-authored-by: Sarah Boyce <42296566+...@users.noreply.github.com>

Backport of 729266c6f29c7a0677b24926a86a767ef3078b26 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34982#comment:10>

Django

unread,
Nov 27, 2023, 1:22:49 PM11/27/23
to django-...@googlegroups.com
#34982: Visual regression for helptext at certain screen sizes
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"bd0ea8c2ba9943ed245771265f55645dc3bfeae8" bd0ea8c]:
{{{
#!CommitTicketReference repository=""
revision="bd0ea8c2ba9943ed245771265f55645dc3bfeae8"
[4.2.x] Fixed #34982 -- Fixed admin's read-only password widget and help


texts alignment for tablet screen size.

Co-authored-by: Sarah Boyce <42296566+...@users.noreply.github.com>

Backport of 729266c6f29c7a0677b24926a86a767ef3078b26 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34982#comment:11>

Django

unread,
Nov 30, 2023, 5:03:12 AM11/30/23
to django-...@googlegroups.com
#34982: Visual regression for helptext at certain screen sizes
----------------------------------+---------------------------------------

Reporter: Mariusz Felisiak | Owner: Tom Carrick
Type: Bug | Status: new

Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):

* status: closed => new
* resolution: fixed =>
* stage: Ready for checkin => Accepted


Comment:

Reopening as RTL issue is not solved (check out #35003).

--
Ticket URL: <https://code.djangoproject.com/ticket/34982#comment:12>

Django

unread,
Nov 30, 2023, 5:22:56 AM11/30/23
to django-...@googlegroups.com
#34982: Visual regression for helptext at certain screen sizes
-------------------------------------+-------------------------------------

Reporter: Mariusz Felisiak | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: new => closed
* resolution: => fixed


* stage: Accepted => Ready for checkin


Comment:

Replying to [comment:12 Mariusz Felisiak]:


> Reopening as RTL issue is not solved (check out #35003).

Decided to close again, as #35003 is related but it's not a regression.

--
Ticket URL: <https://code.djangoproject.com/ticket/34982#comment:13>

Reply all
Reply to author
Forward
0 new messages