[Django] #36727: Deprecate get_placeholder in favor of get_placeholder_sql

1 view
Skip to first unread message

Django

unread,
4:47 PM (4 hours ago) 4:47 PM
to django-...@googlegroups.com
#36727: Deprecate get_placeholder in favor of get_placeholder_sql
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Type:
| Cleanup/optimization
Status: new | Component: Database
| layer (models, ORM)
Version: dev | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
For consistency with other expressions that
[https://docs.djangoproject.com/en/6.0/releases/6.0/#custom-orm-
expressions-should-return-params-as-a-tuple return sql and params
separately] (e.g. `tuple[str, tuple]`), we should deprecate
`get_placeholder` for a `get_placeholder_sql` method that returns
`tuple[str, tuple]` and adapt `BaseSpatialField`, `get_geom_placeholder`,
and other call sites like `Value.as_sql` to make use of it.
--
Ticket URL: <https://code.djangoproject.com/ticket/36727>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
5:54 PM (3 hours ago) 5:54 PM
to django-...@googlegroups.com
#36727: Deprecate get_placeholder in favor of get_placeholder_sql
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* owner: (none) => Simon Charette
* stage: Unreviewed => Accepted
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36727#comment:1>
Reply all
Reply to author
Forward
0 new messages