Re: [Django] #36850: Django Admin filter sidebar wraps if its inner content becomes too large (was: Django Admin filter sidebar wraps if it's inner content becomes too large)

[Django]

#36850: Django Admin filter sidebar wraps if its inner content becomes too large
-------------------------------+--------------------------------------
Reporter: Mark | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: css | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by Mark):

* summary:
Django Admin filter sidebar wraps if it's inner content becomes too
large
=>
Django Admin filter sidebar wraps if its inner content becomes too
large


Old description:

> In the course of ticket [https://code.djangoproject.com/ticket/36511
> #36511] the layout of the changelist and it's filter sidebar has been
> changed so that the sidebar seemling should have a fixed width of 240px.
>
> The flex-base property does in this case not restrict the width of the
> sidebar if it's content demands more (which happens eg. for dropdowns
> with large titles). Combined with the flex: wrap attribute, the sidebar
> wraps if the table also demands more width than available and looks
> broken (see attachment).
>
> This behavior can be simulated by giving a sidebar's and changelist's
> children some fixed, large width:
>
> {{{
> #changelist-filter-extra-actions {
> width: 290px;
> }
> #toolbar {
> width: 1000px;
> }
> }}}
>
> The problem could be resolved by reverting to the previous flex layout
> but the motivation for those changes is unclear to me from the ticket and
> [https://github.com/django/django/pull/19659 related pr].
>
> Should the width of the sidebar stick to 240px or - at it has been before
> - should the sidebar grow if necessary?
>
> Does the new flex layout have any advantages to how it was in django <6?

New description:

In the course of ticket [https://code.djangoproject.com/ticket/36511
#36511] the layout of the changelist and its filter sidebar has been
changed so that the sidebar seemingly should have a fixed width of 240px.

The flex-base property does not necessarily restrict the width of the
sidebar if it's content demands more (which happens eg. for dropdowns with
large titles). Combined with the flex: wrap attribute, the sidebar wraps
if the table also demands more width than available and looks broken (see
attachment).

This behavior can be simulated by giving a sidebar's and changelist's
children some fixed, large width:

{{{
#changelist-filter-extra-actions {
width: 290px;
}
#toolbar {
width: 1000px;
}
}}}

The problem could be resolved by reverting to the previous flex layout,
but the motivation for those changes is unclear to me from the ticket and
[https://github.com/django/django/pull/19659 related pr].

Should the width of the sidebar stick to 240px or - at it has been before
- should the sidebar grow if necessary?

Does the new flex layout have any advantages to how it was in django <6?

--
--
Ticket URL: <https://code.djangoproject.com/ticket/36850#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.