[Django] #31661: makemigrations error message is incomplete
Django
-------------------------------------+-------------------------------------
Reporter: David | Owner: nobody
Smith |
Type: | Status: new
Uncategorized |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I was looking at the gis install instructions and I came across an error
when running makemigrations. (Error is I had not entered password
correctly).
However, the error message that is generated is a bit odd, it has a full
stop on a new line and shows `warnings.warn(`
I was also able to get the same error message on a clean project, with a
postgres database (not gis) and an incorrect password.
I'm not sure if this is a 'bug' but it doesn't look quite right?
{{{
(gis) PS C:\Users\smith\gis\geodjango> python .\manage.py makemigrations
c:\users\smith\pycharmprojects\django2\django\core\management\commands\makemigrations.py:105:
RuntimeWarning: Got an error checking a consistent migration history
performed for database connection 'default': fe_sendauth: no password
supplied
.
warnings.warn(
No changes detected
(gis) PS C:\Users\smith\gis\geodjango>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31661>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
database connection.
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):
* type: Uncategorized => Cleanup/optimization
* component: Database layer (models, ORM) => Core (Management commands)
* easy: 0 => 1
* stage: Unreviewed => Accepted
Comment:
> However, the error message that is generated is a bit odd, it has a full
stop on a new line ...
Newline is from `OperationalError` so there is not much we can do, but I
agree that we should remove a period.
> ... and shows `warnings.warn(`
It's a line where warning is raised, I don't think there is much we can
do.
--
Ticket URL: <https://code.djangoproject.com/ticket/31661#comment:1>
Django
database connection.
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by David Chorpash):
Hello, I'm new to contributing to open source and I feel this would be a
good ticket for me to try. May I claim it?
--
Ticket URL: <https://code.djangoproject.com/ticket/31661#comment:2>
Django
database connection.
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by David Smith):
Replying to [comment:2 David Chorpash]:
> Hello, I'm new to contributing to open source and I feel this would be a
good ticket for me to try. May I claim it?
Absolutely, go for it :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/31661#comment:3>
Django
database connection.
-------------------------------------+-------------------------------------
Type: | Chorpash
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* owner: nobody => David Chorpash
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31661#comment:4>
Django
database connection.
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: David
Type: | Chorpash
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by David Chorpash):
Replying to [comment:3 David Smith]:
> Replying to [comment:2 David Chorpash]:
> > Hello, I'm new to contributing to open source and I feel this would be
a good ticket for me to try. May I claim it?
>
> Absolutely, go for it :-)
Thank you! I will provide a patch removing the period as soon as I can.
Judging by the comments, that's the only part of this ticket I should
expect to make adjustments to.
--
Ticket URL: <https://code.djangoproject.com/ticket/31661#comment:5>
Django
database connection.
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: David
Type: | Chorpash
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by David Chorpash):
* has_patch: 0 => 1
Comment:
Added [https://github.com/django/django/pull/13032 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31661#comment:6>
Django
database connection.
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: David
Type: | Chorpash
Component: Core (Management | Version: master
commands) |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"07506a61147768b95e44ee68d0673851fa5e05bd" 07506a61]:
{{{
#!CommitTicketReference repository=""
revision="07506a61147768b95e44ee68d0673851fa5e05bd"
Fixed #31661 -- Removed period in makemigrations history check warning.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31661#comment:7>