[Django] #31832: PasswordResetTokenGenerator is difficult to extend

13 views
Skip to first unread message

Django

unread,
Jul 27, 2020, 8:05:33 AM7/27/20
to django-...@googlegroups.com
#31832: PasswordResetTokenGenerator is difficult to extend
------------------------------------------------+------------------------
Reporter: Iuri de Silvio | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The `PasswordResetTokenGenerator` is even called `default_token_generator`
but it is not easier to extend because it has a hard coded
`settings.PASSWORD_RESET_TIMEOUT`.

It would be great to reuse this code, just changing `_make_hash_value`,
`key_salt` and `timeout`.

--
Ticket URL: <https://code.djangoproject.com/ticket/31832>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 27, 2020, 8:05:48 AM7/27/20
to django-...@googlegroups.com
#31832: PasswordResetTokenGenerator is difficult to extend
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Iuri de Silvio):

* owner: nobody => Iuri de Silvio
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/31832#comment:1>

Django

unread,
Jul 27, 2020, 8:42:12 AM7/27/20
to django-...@googlegroups.com
#31832: PasswordResetTokenGenerator is difficult to extend
--------------------------------+------------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de Silvio
Type: New feature | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: duplicate

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by felixxm):

* status: assigned => closed
* type: Cleanup/optimization => New feature
* resolution: => duplicate


Comment:

Duplicate of #30423.

--
Ticket URL: <https://code.djangoproject.com/ticket/31832#comment:2>

Django

unread,
Jul 27, 2020, 8:50:58 AM7/27/20
to django-...@googlegroups.com
#31832: PasswordResetTokenGenerator is difficult to extend
--------------------------------+------------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de Silvio
Type: New feature | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: duplicate

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------

Comment (by Iuri de Silvio):

Thanks! I did not found this ticket on my first research.

--
Ticket URL: <https://code.djangoproject.com/ticket/31832#comment:3>

Reply all
Reply to author
Forward
0 new messages