[Django] #24854: Clean up django.db.models.query._values()

[Django]

#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
The `django.db.models.query._values()` method looks like it does much more
than it should be doing in the frontend query class. We should try to move
most of the method into `django.db.models.sql.query` so that other
backends are able to have a better chance of replacing it's functionality.

It might also be worth seeing how much of the method can be factored with
`sql.has_results` since they both setup the query in similar ways.

This comment sparked the idea:
https://github.com/django/django/pull/4706#issuecomment-105130864

--
Ticket URL: <https://code.djangoproject.com/ticket/24854>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by timgraham):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/24854#comment:1>

[Django]

#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner:

Type: | marissazhou
Cleanup/optimization | Status: assigned

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by marissazhou):

* owner: nobody => marissazhou
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/24854#comment:2>

[Django]

#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner:

Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by marissazhou):

* owner: marissazhou =>
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/24854#comment:3>

[Django]

#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner:

Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by JMGordon):

* cc: JMGordon (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/24854#comment:4>

[Django]

#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------

Reporter: jarshwah | Owner: Ian-Foote
Type: | Status: assigned

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Ian-Foote):

* owner: => Ian-Foote

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/24854#comment:5>

[Django]

#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------

Reporter: jarshwah | Owner: Ian-Foote
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Ian-Foote):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/24854#comment:6>

[Django]

#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------

Reporter: jarshwah | Owner: Ian-Foote
Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Markus Holtermann <info@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"698be78d7438aade49d3cac5ea1f9de219d33e42" 698be78]:
{{{
#!CommitTicketReference repository=""
revision="698be78d7438aade49d3cac5ea1f9de219d33e42"
Fixed #24854 -- Refactored QuerySet._values

Added django.db.models.sql.query.Query.set_values() method to handle
query mutation.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24854#comment:7>