[Django] #22897: Made query_string argument to QueryDict optional

1 view
Skip to first unread message

Django

unread,
Jun 24, 2014, 9:52:36 PM6/24/14
to django-...@googlegroups.com
#22897: Made query_string argument to QueryDict optional
------------------------------------------------+------------------------
Reporter: duncan@… | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Previously, a blank QueryDict could be created by calling

`QueryDict(str(''))` or `QueryDict(None)`

It seems rather nicer to just allow the query_string argument to
default to None so that we can just write QueryDict().

It's a commit in ​https://github.com/django/django/pull/2778

--
Ticket URL: <https://code.djangoproject.com/ticket/22897>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 24, 2014, 9:52:44 PM6/24/14
to django-...@googlegroups.com
#22897: Make query_string argument to QueryDict optional
--------------------------------------+------------------------------------

Reporter: duncan@… | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timo):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/22897#comment:1>

Django

unread,
Jun 24, 2014, 10:02:33 PM6/24/14
to django-...@googlegroups.com
#22897: Make query_string argument to QueryDict optional
--------------------------------------+------------------------------------
Reporter: duncan@… | Owner: nobody
Type: Cleanup/optimization | Status: closed

Component: HTTP handling | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"d68987ae25f0e0fb30727473803758af53d75671"]:
{{{
#!CommitTicketReference repository=""
revision="d68987ae25f0e0fb30727473803758af53d75671"
Fixed #22897 -- Made QueryDict query_string argument optional.

Now QueryDict() is equivalent to QueryDict('') or QueryDict(None).
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22897#comment:2>

Django

unread,
May 3, 2016, 12:10:43 PM5/3/16
to django-...@googlegroups.com
#22897: Make query_string argument to QueryDict optional
--------------------------------------+------------------------------------
Reporter: duncan@… | Owner: nobody
Type: Cleanup/optimization | Status: closed

Component: HTTP handling | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"ead21a1949e408cf37226049559d0e71e3fdff6d" ead21a1]:
{{{
#!CommitTicketReference repository=""
revision="ead21a1949e408cf37226049559d0e71e3fdff6d"
Refs #22897 -- Removed unneeded empty string QueryDict argument.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22897#comment:3>

Reply all
Reply to author
Forward
0 new messages