Re: [Django] #36459: Improve accessibility of the buttons inside the AdminDateWidget dialog using ARIA attributes

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
shortcut |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Antoliny):

* owner: (none) => Antoliny
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
shortcut |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Antoliny):

Replying to [comment:1 Sarah Boyce]:
> I think this ticket is worth keeping to track that the current design
has accessibility problems.
>
> I do however think that we might want to deprecate the `AdminDateWidget`
and instead use the HTML5 `<input type="date">` (see
https://developer.mozilla.org/en-
US/docs/Web/HTML/Reference/Elements/input/date) which has a datepicker
native to the browser. I believe this is more accessible than what we have
(see also https://www.youtube.com/watch?v=f2pkCDcAUwA). It also stops us
having something custom we need to maintain and improve the accessibility
of.

I agree. It’s good that there is no need to maintain a custom widget or
improve its accessibility separately.
Additionally, it is true that the `<input type="date">` tag has better
accessibility and usability compared to the current `AdminDateWidget`.
However, I think there are a few issues.
As far as I know, `<input type="date">` makes it a bit difficult to freely
customize the input format.
I understand that the input format changes according to the browser’s
locale, whereas `AdminDateWidget` offers a bit more flexibility in that
regard.

Also, when considering consistency in styling between Date fields and
their subordinate Time fields, such as in DateTime inputs, it might feel
somewhat awkward.
Of course, this might be adjustable.
In my opinion, improving accessibility while keeping the current widget is
also perfectly fine.
What do you think about making it by referring to this
[https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples
/datepicker-dialog/ site]?

Not only for accessibility, but it would also be great to add buttons that
allow quickly jumping(previous year, next year) year :)
--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:3>

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------

Reporter: Antoliny | Owner: Sachi
Type: | Jain
Cleanup/optimization | Status: assigned

Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
shortcut |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sachi Jain):

* has_patch: 0 => 1
* owner: Antoliny => Sachi Jain

Comment:

PR : https://github.com/django/django/pull/20913
--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:4>

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Sachi
Type: | Jain
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
shortcut |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:5>

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Sachi
Type: | Jain
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
shortcut |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sachi Jain):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:6>

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Sachi
Type: | Jain
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:

Keywords: accessibility, | Triage Stage: Ready for
shortcut | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin

Comment:

Good to go once merge conflicts resolved.
--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:7>

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Sachi
Type: | Jain
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:

Keywords: accessibility, | Triage Stage: Accepted
shortcut |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* needs_better_patch: 0 => 1

* stage: Ready for checkin => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:8>

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Sachi
Type: | Jain
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
shortcut |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sachi Jain):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:9>

[Django]

#36459: Improve accessibility of the buttons inside the AdminDateWidget dialog
using ARIA attributes
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Sachi
Type: | Jain
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
shortcut |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36459#comment:10>