[Django] #26622: Improve timezone documentation regarding requirement for pytz
Django
------------------------------------------------+------------------------
Reporter: jarshwah | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
While implementing tests for #25774 it was difficult to determine whether
or not pytz had to be installed or not for certain timezone operations to
work.
The documentation at
https://docs.djangoproject.com/en/dev/topics/i18n/timezones/ mentions:
> Installing pytz is highly recommended, but may not be mandatory
depending on your particular database backend, operating system and time
zone. If you encounter an exception querying dates or times, please try
installing it before filing a bug.
I think it'd be a good idea to be more explicit with this recommendation,
potentially providing a matrix of "database, operating system platform,
pytz required?". We can codify this as a database feature so we can make
use of it in tests, and allow 3rd party backends to define their own
requirements for platform and pytz.
Alternatively we can just fully require pytz for timezone support and
error early if it's not installed (on startup?).
Whoever takes this ticket will need to do some experimentation on linux
and windows with all of the core databases to properly determine
requirements. I can help with oracle on linux if needed.
Preliminary investigation by Tim in #25774 seems to show that all
databases require pytz on Windows for the tests in 25774 at least. There
may be some basic timezone operations that do not depend on pytz which
would be nice to account for, but maybe not necessary.
--
Ticket URL: <https://code.djangoproject.com/ticket/26622>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: jarshwah | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
Comment:
[https://groups.google.com/d/topic/django-
developers/OAV3FChfuPM/discussion django-developers discussion]
--
Ticket URL: <https://code.djangoproject.com/ticket/26622#comment:1>
Django
Reporter: Josh Smeaton | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by François Freitag):
I believe this ticket can be closed now since
[https://github.com/django/django/commit/414ad25b090a63eaaf297b1164c8f7d814a710a2
#diff-2eeaed663bd0d25b7e608891384b7298R50 pytz is required]?
--
Ticket URL: <https://code.djangoproject.com/ticket/26622#comment:2>
Django
Reporter: Josh Smeaton | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* status: new => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/26622#comment:3>