[Django] #29417: Admin title still says "Change [model]" when user has view-only permission
Django
-------------------------------------------+------------------------
Reporter: Matthew Frazier | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-------------------------------------------+------------------------
When the admin user has the "view" permission for a model but doesn't have
the "change" permission, the title of the change view still says "Change
[model]", and the title of the change list view still says "Select [model]
to change." Since the admin index page displays "View" instead of "Change"
on the link to the changelist when the user only has the view permission,
it would make sense to change the title of the changelist and change views
as well.
--
Ticket URL: <https://code.djangoproject.com/ticket/29417>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: leafstorm | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.1
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by leafstorm):
* Attachment "Django bug report - Change on view-only changelist.png"
added.
Screenshot on changelist view
Django
Reporter: Matthew Frazier | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.1
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Matthew Frazier):
* Attachment "Django bug report - Change on view-only page.png" added.
Screenshot on change view
Django
Reporter: Matthew Frazier | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Tim Graham):
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/29417#comment:1>
Django
Reporter: Matthew Frazier | Owner: Paulo
Type: Bug | Status: assigned
Component: contrib.admin | Version: 2.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Paulo):
* owner: nobody => Paulo
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/29417#comment:2>
Django
Reporter: Matthew Frazier | Owner: Paulo
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Ramiro Morales):
Ugh. forgot to assign this to myself.
I have a patch almost ready for review. Will open a PR for you to peruse
in a few minutes.
--
Ticket URL: <https://code.djangoproject.com/ticket/29417#comment:3>
Django
Reporter: Matthew Frazier | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 2.1
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Paulo):
* status: assigned => new
* owner: Paulo => (none)
Comment:
No worries, unassigned myself :)
--
Ticket URL: <https://code.djangoproject.com/ticket/29417#comment:4>
Django
Reporter: Matthew Frazier | Owner: Ramiro
| Morales
Type: Bug | Status: assigned
Component: contrib.admin | Version: 2.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Ramiro Morales):
* status: new => assigned
* owner: (none) => Ramiro Morales
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/9966 PR]
Open question: What the titles/headers shoudl be if the user has
permission to both view and delete an object? 'Change article' doesn't
sound completely correct, but neither does 'View article'.
--
Ticket URL: <https://code.djangoproject.com/ticket/29417#comment:5>
Django
Reporter: Matthew Frazier | Owner: Ramiro
| Morales
Component: contrib.admin | Version: 2.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"f40e71a957aa00b4572c19b269179cded6c8c500" f40e71a]:
{{{
#!CommitTicketReference repository=""
revision="f40e71a957aa00b4572c19b269179cded6c8c500"
Fixed #29417 -- Corrected two admin page titles for view-only users.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29417#comment:6>
Django
Reporter: Matthew Frazier | Owner: Ramiro
| Morales
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Tim Graham <timograham@…>):
In [changeset:"c56d94c02abbc10c71762f7ce9e352a67cb0d485" c56d94c]:
{{{
#!CommitTicketReference repository=""
revision="c56d94c02abbc10c71762f7ce9e352a67cb0d485"
[2.1.x] Fixed #29417 -- Corrected two admin page titles for view-only
users.
Backport of f40e71a957aa00b4572c19b269179cded6c8c500 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29417#comment:7>