[Django] #25259: Add Django version in a comment (hint) to auto-generated migration files
Django
-----------------------------+------------------------
Reporter: tysonclugg | Owner: nobody
Type: New feature | Status: new
Component: Migrations | Version: master
Severity: Normal | Keywords: migrations
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------+------------------------
Add a comment such as:
{{{#!python
# Generated by Django 1.8.3 on 2015-08-11 16:50:15
}}}
This will help identify possible future compatibility issues with
migrations.
--
Ticket URL: <https://code.djangoproject.com/ticket/25259>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: tysonclugg | Owner: nobody
Type: New feature | Status: new
Component: Migrations | Version: master
Keywords: migrations | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by MarkusH):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:1>
Django
Reporter: tysonclugg | Owner: tysonclugg
Type: New feature | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: migrations | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by tysonclugg):
* owner: nobody => tysonclugg
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:2>
Django
Reporter: tysonclugg | Owner: tysonclugg
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: migrations | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by tysonclugg):
* has_patch: 0 => 1
Comment:
PR https://github.com/django/django/pull/5129
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:3>
Django
Reporter: tysonclugg | Owner: tysonclugg
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: migrations | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:4>
Django
Reporter: tysonclugg | Owner: tysonclugg
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: migrations | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by tysonclugg):
Replying to [comment:4 timgraham]:
Could you please elaborate as to what improvements you were expecting?
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:5>
Django
Reporter: tysonclugg | Owner: tysonclugg
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: migrations | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by claudep):
At least tests should pass: http://djangoci.com/job/pull-requests-
trusty/2966/
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:6>
Django
Reporter: tysonclugg | Owner: tysonclugg
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: migrations | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by tysonclugg):
@claudep - the tests ''do'' pass as per my comment in the PR - build 2966
is against an old revision, 2973 is for the current revision and passes:
Tests at http://djangoci.com/job/pull-requests-trusty/2973/ show that
revision ac9a6a5 passes.
I made the above comment in the PR as that's where all the other build
results are shown, adding the exact same comment here seemed like
redundant noise.
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:7>
Django
Reporter: tysonclugg | Owner: tysonclugg
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: migrations | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by MarkusH):
* needs_better_patch: 1 => 0
Comment:
Updated PR: https://github.com/django/django/pull/5211
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:8>
Django
Reporter: tysonclugg | Owner: tysonclugg
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: migrations | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:9>
Django
Reporter: tysonclugg | Owner: tysonclugg
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed
Keywords: migrations | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Markus Holtermann <info@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e34226fc37dfa9eba89d913fd7ab8e95663b0d64" e34226f]:
{{{
#!CommitTicketReference repository=""
revision="e34226fc37dfa9eba89d913fd7ab8e95663b0d64"
Fixed #25259 -- Added comments to header of generated migration files
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25259#comment:10>