Re: [Django] #11495: Improvements to django.views.static.serve directory indexes
Django
-------------------------------------+-------------------------------------
Reporter: SmileyChris | Owner:
Type: | SmileyChris
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 1
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by jezdez):
* needs_better_patch: 0 => 1
Comment:
The branch isn't there anymore, any chance to update the patch here?
--
Ticket URL: <https://code.djangoproject.com/ticket/11495#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: SmileyChris | Owner:
Type: | SmileyChris
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 1
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by SmileyChris):
I haven't looked at updating the branch, but it can be found here now
(tied to the old django/django github repo):
https://github.com/SmileyChris/django-old/compare/master...11495-static-
directory-indexes
--
Ticket URL: <https://code.djangoproject.com/ticket/11495#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: SmileyChris | Owner:
Type: | SmileyChris
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 1
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
What is the use case for this?
--
Ticket URL: <https://code.djangoproject.com/ticket/11495#comment:15>
Django
Reporter: SmileyChris | Owner: SmileyChris
Type: Bug | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
------------------------------+---------------------------------------
Changes (by ptone):
* version: 1.0 => master
* type: Cleanup/optimization => Bug
* stage: Design decision needed => Accepted
Comment:
Why should views.static.serve consider static file finders? As documented
it is just a directory based tool.
I'd move to splitting this into two tickets. Accept this one which has the
narrow scope of standardizing the sort order across OS versions for basic
static.serve, I think this isn't too contentious.
The issue of how to incorporate static-file finders into index display can
be sorted out separately, with its rationale and design proposal.
--
Ticket URL: <https://code.djangoproject.com/ticket/11495#comment:16>
Django
------------------------------+---------------------------------------
Reporter: SmileyChris | Owner: SmileyChris
Type: Bug | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
------------------------------+---------------------------------------
* cc: cmawebsite@… (added)
* keywords: => static
Comment:
I think we should deprecate and remove `show_indexes` completely. What do
people use it for?
--
Ticket URL: <https://code.djangoproject.com/ticket/11495#comment:17>
Django
------------------------------+---------------------------------------
Reporter: SmileyChris | Owner: SmileyChris
Type: Bug | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: static | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
------------------------------+---------------------------------------
Comment (by timgraham):
It seems `show_indexes` dates back to when the view was first added in
572ac3e7dfadec6434527ebbdccef97de1cc191c. I didn't see any mention in the
ticket about why this functionality was needed. I guess it makes it a bit
easier to debug if you have a typo in a file name or something (rather
than opening up a file browser). Collin, can you present your rationale
for deprecating it? No doubt some people like it and use it.
--
Ticket URL: <https://code.djangoproject.com/ticket/11495#comment:18>
Django
------------------------------+---------------------------------------
Reporter: SmileyChris | Owner: SmileyChris
Type: Bug | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: static | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
------------------------------+---------------------------------------
Comment (by collinanderson):
My goal would be to start fully supporting using static.serve() (or
something like it) in production (in 1.9), but we wouldn't want to support
show_indexes in production.
Also, as mentioned, now that we have the staticfiles framework, this
little feature is a lot harder to get right.
It seems to me, if you want a web index of files, you could just run
`python3 -m http.server 8080`.
There's also this django-developers discussion:
https://groups.google.com/d/topic/django-developers/N0KbgDeLuUE/discussion
--
Ticket URL: <https://code.djangoproject.com/ticket/11495#comment:19>
Django
------------------------------+---------------------------------------
Reporter: SmileyChris | Owner: SmileyChris
Component: Core (Other) | Version: master
Keywords: static | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
------------------------------+---------------------------------------
* status: assigned => closed
* resolution: => wontfix
--
Ticket URL: <https://code.djangoproject.com/ticket/11495#comment:20>