[Django] #32790: Django test client redirecting to URLs without a trailing slash redirects instead to the current view
Django
instead to the current view
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
tomhamiltonstubber |
Type: Bug | Status: new
Component: Testing | Version: 3.2
framework |
Severity: Normal | Keywords: Test client
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently, when you redirect with the test client to an external URL
without a trailing slash, the test client will redirect to the view you
redirected from.
For example, if I test a view at `/my-view/` that redirects to
`https://example.com`, the test client will instead redirect to `/my-
view/`.
Presumably this isn't intended behaviour but feel free to correct me.
--
Ticket URL: <https://code.djangoproject.com/ticket/32790>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
instead to the current view
-------------------------------------+-------------------------------------
| tomhamiltonstubber
Type: Bug | Status: assigned
Component: Testing framework | Version: 3.2
Severity: Normal | Resolution:
Keywords: Test client | Triage Stage:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => tomhamiltonstubber
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/32790#comment:1>
Django
instead to the current view
-------------------------------------+-------------------------------------
| tomhamiltonstubber
Type: Bug | Status: assigned
Component: Testing framework | Version: 3.2
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by tomhamiltonstubber):
PR https://github.com/django/django/pull/14457
--
Ticket URL: <https://code.djangoproject.com/ticket/32790#comment:2>
Django
instead to the current view
-------------------------------------+-------------------------------------
| tomhamiltonstubber
Type: Bug | Status: assigned
Component: Testing framework | Version: 3.2
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32790#comment:3>
Django
instead to the current view
-------------------------------------+-------------------------------------
Stubber | Hamilton Stubber
Type: Bug | Status: assigned
Component: Testing framework | Version: 3.2
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Ready for checkin => Unreviewed
Comment:
You shouldn't accept or mark as RFC your own tickets/PRs.
--
Ticket URL: <https://code.djangoproject.com/ticket/32790#comment:4>
Django
instead to the current view
-------------------------------------+-------------------------------------
Stubber | Hamilton Stubber
Type: Bug | Status: assigned
Component: Testing framework | Version: 3.2
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
I think this is probably valid. I su
[https://datatracker.ietf.org/doc/html/rfc2616#section-3.2.2 RFC 2616
(HTTP/1.1) has this for an HTTP URL]:
{{{
http_URL = "http:" "//" host [ ":" port ] [ abs_path [ "?" query ]]
}}}
It then says:
> If the abs_path is not present in the URL, it MUST be given as "/" when
used as a Request-URI for a resource.
i.e. the client MUST treat `https://example.com` as
`https://example.com/`.
(Inclined towards thinking this should probably apply to the `Location`
headers **set by the server** too, but the test client can't control for
that.)
--
Ticket URL: <https://code.djangoproject.com/ticket/32790#comment:5>
Django
instead to the current view
-------------------------------------+-------------------------------------
Stubber | Hamilton Stubber
Type: Bug | Status: assigned
Component: Testing framework | Version: 3.2
Severity: Normal | Resolution:
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32790#comment:6>
Django
instead to the current view
-------------------------------------+-------------------------------------
Stubber | Hamilton Stubber
Component: Testing framework | Version: 3.2
Keywords: Test client | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"1e5aa8e1c79252cc810af21294a6e945d11d37b3" 1e5aa8e1]:
{{{
#!CommitTicketReference repository=""
revision="1e5aa8e1c79252cc810af21294a6e945d11d37b3"
Fixed #32790 -- Ensured test Client handles redirects to domain indexes
without a specified trailing slash.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32790#comment:7>