[Django] #25058: GenericRelation with related_query_name related instances not shown on delete confirmation page

33 views
Skip to first unread message

Django

unread,
Jul 3, 2015, 8:31:18 AM7/3/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
-------------------------------+--------------------
Reporter: jmfederico | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------
When deleting an object with a GenericRelation and related_query_name, the
related instances are not shown on the confirmation page.

Instances are actually deleted and the confirmation page show the correct
count of related instances to be deleted.

Related to #24940, which fixes an issue where it wasn't possible to delete
the instances.

--
Ticket URL: <https://code.djangoproject.com/ticket/25058>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 3, 2015, 8:34:57 AM7/3/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
---------------------------+----------------------------

Reporter: jmfederico | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 1 |
---------------------------+----------------------------
Changes (by jmfederico):

* Attachment "Screen Shot 2015-07-03 at 7.31.41.png" added.

Django

unread,
Jul 3, 2015, 9:06:41 PM7/3/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
-------------------------------+------------------------------------
Reporter: jmfederico | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_docs: => 0
* type: Uncategorized => Bug
* needs_tests: => 0
* stage: Unreviewed => Accepted


Comment:

I can reproduce the issue. For the regression test, we should be able to
make some additions to the test added in
d3d66d47222dd8765a20a15fdc754c0ed7635404.

--
Ticket URL: <https://code.djangoproject.com/ticket/25058#comment:1>

Django

unread,
Jul 13, 2015, 12:38:17 PM7/13/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
-------------------------------+-------------------------------------------
Reporter: jmfederico | Owner: andersonresende
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.8

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+-------------------------------------------
Changes (by andersonresende):

* owner: nobody => andersonresende
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/25058#comment:2>

Django

unread,
Aug 25, 2015, 4:16:57 PM8/25/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
-------------------------------+----------------------------------------
Reporter: jmfederico | Owner: sarthakmeh03
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.8

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+----------------------------------------
Changes (by sarthakmeh03):

* owner: andersonresende => sarthakmeh03


--
Ticket URL: <https://code.djangoproject.com/ticket/25058#comment:3>

Django

unread,
Aug 26, 2015, 6:16:55 PM8/26/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
-------------------------------+----------------------------------------
Reporter: jmfederico | Owner: sarthakmeh03
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.8

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+----------------------------------------
Changes (by sarthakmeh03):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/5198]

--
Ticket URL: <https://code.djangoproject.com/ticket/25058#comment:4>

Django

unread,
Aug 26, 2015, 6:34:13 PM8/26/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
-------------------------------+----------------------------------------
Reporter: jmfederico | Owner: sarthakmeh03
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.8

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+----------------------------------------
Changes (by timgraham):

* needs_tests: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25058#comment:5>

Django

unread,
Aug 27, 2015, 3:30:05 PM8/27/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
-------------------------------+----------------------------------------
Reporter: jmfederico | Owner: sarthakmeh03
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.8

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+----------------------------------------
Changes (by sarthakmeh03):

* needs_tests: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25058#comment:6>

Django

unread,
Sep 3, 2015, 10:09:46 AM9/3/15
to django-...@googlegroups.com
#25058: GenericRelation with related_query_name related instances not shown on
delete confirmation page
-------------------------------+----------------------------------------
Reporter: jmfederico | Owner: sarthakmeh03
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+----------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"40bf18e70282784c7923a89c0700a83118b81a50" 40bf18e7]:
{{{
#!CommitTicketReference repository=""
revision="40bf18e70282784c7923a89c0700a83118b81a50"
Fixed #25058 -- Added GenericRelations with related_query_name to the
admin's delete confirmation page.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25058#comment:7>

Reply all
Reply to author
Forward
0 new messages