[Django] #21013: Admin history should consider ModelAdmin.get_queryset
Django
-------------------------------+--------------------
Reporter: jonash | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
* Model with custom default manager that excludes some objects
* ModelAdmin with custom `get_queryset` that includes more objects than
the manager
* History view throws 404 for any objects that aren't included the default
manager because it doesn't consider the ModelAdmin's `get_queryset`
method.
Test an fix attached. Tests are probably in the wrong place and need to be
moved.
--
Ticket URL: <https://code.djangoproject.com/ticket/21013>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: jonash | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by jonash):
* needs_better_patch: => 1
* has_patch: 0 => 1
* component: Uncategorized => contrib.admin
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/21013#comment:1>
Django
Reporter: jonash | Owner: jcatalan
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 1.5
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by jcatalan):
* owner: nobody => jcatalan
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/21013#comment:2>
Django
Reporter: jonash | Owner: jcatalan
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 1.5
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by jcatalan):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/21013#comment:3>
Django
Reporter: jonash | Owner: jcatalan
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by jcatalan):
I've checked the test and the patch and everything seems to be right. I'll
submit a PR and see if I can get some code review by a core dev.
--
Ticket URL: <https://code.djangoproject.com/ticket/21013#comment:4>
Django
Reporter: jonash | Owner: jcatalan
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 1.5
Severity: Normal | Resolution:
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by jcatalan):
* stage: Accepted => Ready for checkin
Comment:
I've submited a PR with your patch, so I'm changing this to Ready for
checkin though I still have to check if the test case is well located or
change it in case it's not.
--
Ticket URL: <https://code.djangoproject.com/ticket/21013#comment:5>
Django
Reporter: jonash | Owner: jcatalan
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
* cc: jonas-django@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/21013#comment:6>
Django
Reporter: jonash | Owner: jcatalan
Component: contrib.admin | Version: 1.5
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"04415bf81b2440a08fc224e6c481bcb5840bbcbc"]:
{{{
#!CommitTicketReference repository=""
revision="04415bf81b2440a08fc224e6c481bcb5840bbcbc"
Fixed #21013 -- Ensure that ModelAdmin.get_queryset is considered for the
admin history view.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21013#comment:7>