Re: [Django] #35358: Rename BaseConstraint._check() to check() (was: Rename BaseConstraint._check to check once the deprecation period)

[Django]

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 6.0 | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* keywords: => 6.0
* stage: Unreviewed => Someday/Maybe
* summary: Rename BaseConstraint._check to check once the deprecation
period => Rename BaseConstraint._check() to check()


Old description:

> [https://github.com/django/django/pull/17876/files#r1508517275 Per this
> comment] this is tracking renaming the `BaseConstraint._check` method to
> `check` when the ungoing deprecation period for `BaseConstraint.check`
> (now `.condition`) ends.
>
> Not sure if there is a better way to categorize this ticket so it doesn't
> fall between the cracks when the deprecation period ends.

New description:

[https://github.com/django/django/pull/17876/files#r1508517275 Per this
comment] , `BaseConstraint._check()` should be renamed to `check()` in
Django 6.0 when the deprecation period for `BaseConstraint.check` (now
`.condition`) ends.

--
Comment:

For past releases, I put the Django version number in the keywords field
and used that Trac query
([https://code.djangoproject.com/query?keywords=~1.11&stage=Accepted&status=assigned&status=closed&status=new&order=changetime&desc=1&col=id&col=summary&col=status&col=owner&col=type&col=version&col=changetime
example]).
--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.