[Django] #24478: Icelandic thousand separator not working without number grouping value

9 views
Skip to first unread message

Django

unread,
Mar 13, 2015, 11:03:47 AM3/13/15
to django-...@googlegroups.com
#24478: Icelandic thousand separator not working without number grouping value
--------------------------------------+-------------------------------
Reporter: saevarom | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: 1.7
Severity: Normal | Keywords: l10n localization
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+-------------------------------
The USE_THOUSAND_SEPARATOR setting is not working when format localizing
Icelandic numbers.

A properly formatted number in Icelandic should be: 1.000.000,0 - however
- when using the `localize` template tag to format numbers, no thousand
separators appear. This is due to the fact that in
django/utils/numberformat.py no grouping occurs unless there is a non-zero
value for the NUMBER_GROUPING variable in the active locale.

This patch sets a default value for NUMBER_GROUPING = 3 to enable properly
formatting of Icelandic numbers.

--
Ticket URL: <https://code.djangoproject.com/ticket/24478>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 13, 2015, 11:04:10 AM3/13/15
to django-...@googlegroups.com
#24478: Icelandic thousand separator not working without number grouping value
----------------------------------+----------------------------

Reporter: saevarom | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: 1.7
Severity: Normal | Resolution:

Keywords: l10n localization | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 1
UI/UX: 0 |
----------------------------------+----------------------------
Changes (by saevarom):

* Attachment "is_formatting.patch" added.

Django

unread,
Mar 13, 2015, 11:12:24 AM3/13/15
to django-...@googlegroups.com
#24478: Icelandic thousand separator not working without number grouping value
-------------------------------------+-------------------------------------

Reporter: saevarom | Owner: nobody
Type: Bug | Status: new
Component: | Version: 1.7
Internationalization |
Severity: Normal | Resolution:

Keywords: l10n localization | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by saevarom):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

Pull request submitted: https://github.com/django/django/pull/4314

--
Ticket URL: <https://code.djangoproject.com/ticket/24478#comment:1>

Django

unread,
Mar 13, 2015, 11:57:22 AM3/13/15
to django-...@googlegroups.com
#24478: Icelandic thousand separator not working without number grouping value
-------------------------------------+-------------------------------------
Reporter: saevarom | Owner: nobody
Type: Bug | Status: closed
Component: | Version: 1.7
Internationalization |
Severity: Normal | Resolution: fixed

Keywords: l10n localization | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"d8de9a64d70f4bef7a223da1559638699a7a3923" d8de9a64]:
{{{
#!CommitTicketReference repository=""
revision="d8de9a64d70f4bef7a223da1559638699a7a3923"
Fixed #24478 -- Added NUMBER_GROUPING value for Icelandic
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24478#comment:2>

Django

unread,
Mar 13, 2015, 11:58:15 AM3/13/15
to django-...@googlegroups.com
#24478: Icelandic thousand separator not working without number grouping value
-------------------------------------+-------------------------------------
Reporter: saevarom | Owner: nobody

Type: Bug | Status: closed
Component: | Version: 1.7
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: l10n localization | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"8fe451d183fbcd298d4da659af31dfe341e2252f" 8fe451d1]:
{{{
#!CommitTicketReference repository=""
revision="8fe451d183fbcd298d4da659af31dfe341e2252f"
[1.8.x] Fixed #24478 -- Added NUMBER_GROUPING value for Icelandic

Backport of d8de9a64d7 from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24478#comment:3>

Reply all
Reply to author
Forward
0 new messages