[Django] #20861: 500 status code debugging view shouldn't localize numeric tags IDs/line numbers
Django
numbers
--------------------------------------+------------------------
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------+------------------------
Contributor Kronuz opened a pull request
(https://github.com/django/django/pull/451) with a proposed fix to the
issue.
I've added tests here: https://github.com/django/django/pull/1437
One thing missing in the proposed fix was importing the `l10n` template
tag library (the one that contains the `unlocalize` filter) and this
stopped me from merging the PR right away.
Until now the template is pretty self-contained and lean, e.g. it doesn't
import template tag libraries (I suspect to minimize the risk of
triggering other problems when trying to show a helpful version of the
server error exceptions.)
Should I ignore all this and simply commit the fix?
--
Ticket URL: <https://code.djangoproject.com/ticket/20861>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
numbers
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by ramiro):
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
New strategy that is less invasive, IMHO: Specify use_l10n=False when
constructing the Context for the debug view. PR updated.
I plan to commit this soon
--
Ticket URL: <https://code.djangoproject.com/ticket/20861#comment:1>
Django
numbers
Reporter: ramiro | Owner: nobody
Type: Bug | Status: closed
Component: Utilities | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Ramiro Morales <cramm0@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"6c12cd15e990b0ff5a5e85328f0a092f4bfe8080"]:
{{{
#!CommitTicketReference repository=""
revision="6c12cd15e990b0ff5a5e85328f0a092f4bfe8080"
Unlocalize line numbers and ids in debug 500 view.
While using USE_L10N, line numbers and IDs were printed as comma (or
locale equivalent) separated values.
Thanks Kronuz for the report and intial patch.
Fixes #20861.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20861#comment:2>