[Django] #32766: Unused ORDER_TYPE_VAR variable in admin changelist code

13 views
Skip to first unread message

Django

unread,
May 19, 2021, 12:21:38 AM5/19/21
to django-...@googlegroups.com
#32766: Unused ORDER_TYPE_VAR variable in admin changelist code
------------------------------------------------+------------------------
Reporter: David Sanders | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
There are no current usages of `ORDER_TYPE_VAR`, and it appears it became
dead code in the 1.4 release, so seems safe enough to remove since it's
been nearly a decade.

--
Ticket URL: <https://code.djangoproject.com/ticket/32766>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 19, 2021, 1:47:23 AM5/19/21
to django-...@googlegroups.com
#32766: Unused ORDER_TYPE_VAR variable in admin changelist code
-------------------------------------+-------------------------------------
Reporter: David Sanders | Owner: David
Type: | Sanders
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => David Sanders
* status: new => assigned
* has_patch: 0 => 1
* stage: Unreviewed => Accepted


Comment:

Agreed, unused since 5434ce231d75004bdbe5cf2b7b24ce67a2a6e737.

[https://github.com/django/django/pull/14413 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/32766#comment:1>

Django

unread,
May 19, 2021, 1:51:27 AM5/19/21
to django-...@googlegroups.com
#32766: Unused ORDER_TYPE_VAR variable in admin changelist code
-------------------------------------+-------------------------------------
Reporter: David Sanders | Owner: David
Type: | Sanders
Cleanup/optimization | Status: closed
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"127fd927d0fa3b7a0b09b7bd1f02f156cc28e491" 127fd927]:
{{{
#!CommitTicketReference repository=""
revision="127fd927d0fa3b7a0b09b7bd1f02f156cc28e491"
Fixed #32766 -- Removed unused ORDER_TYPE_VAR.

Unused since 5434ce231d75004bdbe5cf2b7b24ce67a2a6e737.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32766#comment:2>

Reply all
Reply to author
Forward
0 new messages