[Django] #21892: Remove "string based" RunPython operations.

3 views
Skip to first unread message

Django

unread,
Jan 29, 2014, 12:46:26 AM1/29/14
to django-...@googlegroups.com
#21892: Remove "string based" RunPython operations.
--------------------------------------+-------------------------
Reporter: loic84 | Owner:
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.7-alpha-1
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+-------------------------
Example of "string based" RunPython operation:
{{{
# Create the operation
operation = migrations.RunPython(
"""
Pony = models.get_model("test_runpython", "Pony")
Pony.objects.create(pink=2, weight=4.55)
Pony.objects.create(weight=1)
""",
)
}}}

This removal was discussed on IRC with Andrew, the rationale being that
most Python tooling wouldn't be able to inspect this code and that it
doesn't provide an obvious gain compared to callables.

Marking it as release blocker, since we should remove this feature before
people start using it.

--
Ticket URL: <https://code.djangoproject.com/ticket/21892>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 31, 2014, 1:10:15 PM1/31/14
to django-...@googlegroups.com
#21892: Remove "string based" RunPython operations.
-------------------------------------+-------------------------------------
Reporter: loic84 | Owner:
Type: | Status: new
Cleanup/optimization | Version:
Component: Migrations | 1.7-alpha-1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timo):

* needs_docs: => 0
* needs_better_patch: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/21892#comment:1>

Django

unread,
Feb 9, 2014, 5:54:36 AM2/9/14
to django-...@googlegroups.com
#21892: Remove "string based" RunPython operations.
-------------------------------------+-------------------------------------
Reporter: loic84 | Owner: Andrew
Type: | Godwin <andrew@…>
Cleanup/optimization | Status: closed
Component: Migrations | Version:
Severity: Release blocker | 1.7-alpha-1
Keywords: | Resolution: fixed
Has patch: 0 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Andrew Godwin <andrew@…>):

* status: new => closed
* owner: => Andrew Godwin <andrew@…>
* resolution: => fixed


Comment:

In [changeset:"98dd8dd02e6a005266866ab1cb4a2ec00dce0193"]:
{{{
#!CommitTicketReference repository=""
revision="98dd8dd02e6a005266866ab1cb4a2ec00dce0193"
Fixed #21892: RunPython no longer accepts strings
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21892#comment:2>

Reply all
Reply to author
Forward
0 new messages