[Django] #23463: Add Historical models note to upload_to/limit_choices_to sections
Django
--------------------------------------+-----------------
Reporter: jpadilla | Owner:
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+-----------------
The Historial models section under the Migrations documentation
(https://docs.djangoproject.com/en/dev/topics/migrations/#historical-
models) mentions that "references to functions in field options such as
upload_to and limit_choices_to are serialized in migrations, so the
functions will need to be kept around for as long as there is a migration
referencing them."
I think it'd be useful if we had a note regarding this, and probably
linking to the existing mention, in the upload_to and limit_choices_to
documentation sections.
--
Ticket URL: <https://code.djangoproject.com/ticket/23463>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: jpadilla | Owner:
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by claudep):
* needs_better_patch: => 0
* version: 1.7 => master
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23463#comment:1>
Django
Reporter: jpadilla | Owner:
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by jpadilla):
Working on this here
https://github.com/jpadilla/django/commit/43cdbeecc45402a0d1dec67960a8947c7a5a195f.
Need some guidance/review with wording and placement of the notes.
--
Ticket URL: <https://code.djangoproject.com/ticket/23463#comment:2>
Django
Reporter: jpadilla | Owner: jpadilla
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by jpadilla):
* owner: => jpadilla
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/23463#comment:3>
Django
Reporter: jpadilla | Owner: jpadilla
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by timgraham):
I'm not much of a fan of repeating the note for every field option that
might be a function. For example, `default` is often a function as well.
"Note that references to functions in this field option" might be
misleading, since it's really "references to functions in *all* field
options". I don't really see a good place in the field reference guide for
a common note though. I wonder if a new section in `topics/db/models.txt`
might be better.
--
Ticket URL: <https://code.djangoproject.com/ticket/23463#comment:4>
Django
Reporter: jpadilla | Owner: jpadilla
Component: Documentation | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* status: assigned => closed
* resolution: => wontfix
--
Ticket URL: <https://code.djangoproject.com/ticket/23463#comment:5>