[Django] #35545: Fix create_permissions LookupErrors

[Django]

#35545: Fix create_permissions LookupErrors
--------------------------------------------+------------------------
Reporter: Csirmaz Bendegúz | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 5.1
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+------------------------
[https://code.djangoproject.com/ticket/35408 #35408] introduced a bug in
contrib.auth's create_permissions function
([https://github.com/django/django/pull/18105 PR], commit
d2c5a30e5a8595d06c4a70ff0f66032fee0d3c8e ).
Since this function is called by the post migrate signal, it affects the
migrate command.
The function raises unexpected LookupErrors on Windows systems.

{{{
Operations to perform:
Apply all migrations: admin, auth, contenttypes, dev, sessions
Running migrations:
Applying dev.0001_initial... OK
Traceback (most recent call last):
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\apps\registry.py", line 158, in get_app_config
return self.app_configs[app_label]
~~~~~~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'dev'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\csirm\PycharmProjects\django-dev\django_dev\manage.py",
line 22, in <module>
main()
File "C:\Users\csirm\PycharmProjects\django-dev\django_dev\manage.py",
line 18, in main
execute_from_command_line(sys.argv)
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\core\management\__init__.py", line 442, in
execute_from_command_line
utility.execute()
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\core\management\__init__.py", line 436, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\core\management\base.py", line 413, in run_from_argv
self.execute(*args, **cmd_options)
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\core\management\base.py", line 459, in execute
output = self.handle(*args, **options)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\core\management\base.py", line 107, in wrapper
res = handle_func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\core\management\commands\migrate.py", line 384, in handle
emit_post_migrate_signal(
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\core\management\sql.py", line 52, in
emit_post_migrate_signal
models.signals.post_migrate.send(
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\dispatch\dispatcher.py", line 189, in send
response = receiver(signal=self, sender=sender, **named)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\contrib\auth\management\__init__.py", line 78, in
create_permissions
ctypes = ContentType.objects.db_manager(using).get_for_models(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\contrib\contenttypes\models.py", line 93, in
get_for_models
ct._meta.apps.get_model(ct.app_label, ct.model)._meta, []
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\apps\registry.py", line 208, in get_model
app_config = self.get_app_config(app_label)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-
packages\django\apps\registry.py", line 165, in get_app_config
raise LookupError(message)
LookupError: No installed app with label 'dev'.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35545>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35545: Fix create_permissions LookupErrors
----------------------------------+--------------------------------------

Reporter: Csirmaz Bendegúz | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 5.1

Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

----------------------------------+--------------------------------------
Description changed by Csirmaz Bendegúz:

Old description:

New description:

[https://code.djangoproject.com/ticket/35408 #35408] introduced a bug in
{{{contrib.auth}}}'s {{{create_permissions}}} function
([https://github.com/django/django/pull/18105 PR], commit
{{{d2c5a30e5a8595d06c4a70ff0f66032fee0d3c8e}}}).

Since this function is called by the {{{post_migrate}}} signal, it affects
the {{{migrate}}} command.
The function raises unexpected {{{LookupError}}} s on Windows systems.

--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:1>

[Django]

#35545: Fix create_permissions LookupErrors
----------------------------------+------------------------------------

Reporter: Csirmaz Bendegúz | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 5.1
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------

Changes (by Natalia Bidart):

* cc: Adam Johnson (added)
* stage: Unreviewed => Accepted

Comment:

Thank you Csirmaz for this report!

I can confirm I can reproduce in a simple Django project:
{{{
$ python -Wall manage.py migrate generator
Operations to perform:
Apply all migrations: generator
Running migrations:
Applying generator.0001_initial... OK

Traceback (most recent call last):

File "/home/nessita/fellowship/django/django/apps/registry.py", line

158, in get_app_config
return self.app_configs[app_label]
~~~~~~~~~~~~~~~~^^^^^^^^^^^

KeyError: 'generator'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

File "/home/nessita/fellowship/checklist-generator/manage.py", line 22,
in <module>
main()
File "/home/nessita/fellowship/checklist-generator/manage.py", line 18,
in main
execute_from_command_line(sys.argv)
File
"/home/nessita/fellowship/django/django/core/management/__init__.py", line

442, in execute_from_command_line
utility.execute()
File

"/home/nessita/fellowship/django/django/core/management/__init__.py", line
436, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/home/nessita/fellowship/django/django/core/management/base.py",

line 413, in run_from_argv
self.execute(*args, **cmd_options)

File "/home/nessita/fellowship/django/django/core/management/base.py",

line 459, in execute
output = self.handle(*args, **options)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/home/nessita/fellowship/django/django/core/management/base.py",

line 107, in wrapper
res = handle_func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File

"/home/nessita/fellowship/django/django/core/management/commands/migrate.py",

line 384, in handle
emit_post_migrate_signal(

File "/home/nessita/fellowship/django/django/core/management/sql.py",

line 52, in emit_post_migrate_signal
models.signals.post_migrate.send(

File "/home/nessita/fellowship/django/django/dispatch/dispatcher.py",

line 189, in send
response = receiver(signal=self, sender=sender, **named)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File

"/home/nessita/fellowship/django/django/contrib/auth/management/__init__.py",

line 78, in create_permissions
ctypes = ContentType.objects.db_manager(using).get_for_models(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File

"/home/nessita/fellowship/django/django/contrib/contenttypes/models.py",

line 93, in get_for_models
ct._meta.apps.get_model(ct.app_label, ct.model)._meta, []
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/home/nessita/fellowship/django/django/apps/registry.py", line

208, in get_model
app_config = self.get_app_config(app_label)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/home/nessita/fellowship/django/django/apps/registry.py", line

165, in get_app_config
raise LookupError(message)

LookupError: No installed app with label 'generator'.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:2>

[Django]

#35545: Fix create_permissions LookupErrors
----------------------------------+------------------------------------
Reporter: Csirmaz Bendegúz | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------

Description changed by Csirmaz Bendegúz:

Old description:

> [https://code.djangoproject.com/ticket/35408 #35408] introduced a bug in
> {{{contrib.auth}}}'s {{{create_permissions}}} function
> ([https://github.com/django/django/pull/18105 PR], commit
> {{{d2c5a30e5a8595d06c4a70ff0f66032fee0d3c8e}}}).

> Since this function is called by the {{{post_migrate}}} signal, it
> affects the {{{migrate}}} command.
> The function raises unexpected {{{LookupError}}} s on Windows systems.
>
> {{{

> Operations to perform:

> Apply all migrations: admin, auth, contenttypes, dev, sessions
> Running migrations:

> Applying dev.0001_initial... OK

> Traceback (most recent call last):

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\apps\registry.py", line 158, in get_app_config
> return self.app_configs[app_label]
> ~~~~~~~~~~~~~~~~^^^^^^^^^^^
> KeyError: 'dev'

>
> During handling of the above exception, another exception occurred:
>
> Traceback (most recent call last):

> File "C:\Users\csirm\PycharmProjects\django-dev\django_dev\manage.py",

> line 22, in <module>
> main()

> File "C:\Users\csirm\PycharmProjects\django-dev\django_dev\manage.py",

> line 18, in main
> execute_from_command_line(sys.argv)

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\core\management\__init__.py", line 442, in
> execute_from_command_line
> utility.execute()

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\core\management\__init__.py", line 436, in execute
> self.fetch_command(subcommand).run_from_argv(self.argv)

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\core\management\base.py", line 413, in run_from_argv
> self.execute(*args, **cmd_options)

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\core\management\base.py", line 459, in execute

> output = self.handle(*args, **options)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\core\management\base.py", line 107, in wrapper

> res = handle_func(*args, **kwargs)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\core\management\commands\migrate.py", line 384, in handle
> emit_post_migrate_signal(

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\core\management\sql.py", line 52, in
> emit_post_migrate_signal
> models.signals.post_migrate.send(

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\dispatch\dispatcher.py", line 189, in send

> response = receiver(signal=self, sender=sender, **named)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\contrib\auth\management\__init__.py", line 78, in

> create_permissions
> ctypes = ContentType.objects.db_manager(using).get_for_models(
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\contrib\contenttypes\models.py", line 93, in
> get_for_models
> ct._meta.apps.get_model(ct.app_label, ct.model)._meta, []
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\apps\registry.py", line 208, in get_model
> app_config = self.get_app_config(app_label)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

> packages\django\apps\registry.py", line 165, in get_app_config
> raise LookupError(message)

> LookupError: No installed app with label 'dev'.
> }}}

New description:

[https://code.djangoproject.com/ticket/35408 #35408] introduced a bug in
{{{contrib.auth}}}'s {{{create_permissions}}} function
([https://github.com/django/django/pull/18105 PR], commit
{{{d2c5a30e5a8595d06c4a70ff0f66032fee0d3c8e}}}).
Since this function is called by the {{{post_migrate}}} signal, it affects
the {{{migrate}}} command.

The function raises unexpected {{{LookupError}}} s.

{{{
Operations to perform:

Apply all migrations: admin, auth, contenttypes, dev, sessions
Running migrations:

Applying dev.0001_initial... OK

Traceback (most recent call last):

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\apps\registry.py", line 158, in get_app_config
return self.app_configs[app_label]
~~~~~~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'dev'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

File "C:\Users\csirm\PycharmProjects\django-dev\django_dev\manage.py",

line 22, in <module>
main()

File "C:\Users\csirm\PycharmProjects\django-dev\django_dev\manage.py",

line 18, in main
execute_from_command_line(sys.argv)

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\core\management\__init__.py", line 442, in
execute_from_command_line
utility.execute()

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\core\management\__init__.py", line 436, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\core\management\base.py", line 413, in run_from_argv
self.execute(*args, **cmd_options)

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\core\management\base.py", line 459, in execute

output = self.handle(*args, **options)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\core\management\base.py", line 107, in wrapper

res = handle_func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\core\management\commands\migrate.py", line 384, in handle
emit_post_migrate_signal(

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\core\management\sql.py", line 52, in
emit_post_migrate_signal
models.signals.post_migrate.send(

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\dispatch\dispatcher.py", line 189, in send

response = receiver(signal=self, sender=sender, **named)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\contrib\auth\management\__init__.py", line 78, in

create_permissions
ctypes = ContentType.objects.db_manager(using).get_for_models(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\contrib\contenttypes\models.py", line 93, in
get_for_models
ct._meta.apps.get_model(ct.app_label, ct.model)._meta, []
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\apps\registry.py", line 208, in get_model
app_config = self.get_app_config(app_label)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "C:\Users\csirm\PycharmProjects\django-dev\venv\Lib\site-

packages\django\apps\registry.py", line 165, in get_app_config
raise LookupError(message)
LookupError: No installed app with label 'dev'.
}}}

--
--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:3>

[Django]

#35545: Fix create_permissions LookupErrors
----------------------------------+------------------------------------
Reporter: Csirmaz Bendegúz | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------

Comment (by Sarah Boyce):

Details for people investigating:
- `django.contrib.auth`, `django.contrib.contenttypes` and a third app
(`app1`) needs to be installed
- `migrate` (important)
- create a new model in `app1`
- `makemigrations` and `migrate`

If you were to delete the SQLite db and apply the migrations, it would run
fine which makes me think we have a caching issue in
`ContentTypeManager.get_for_models()` (#31357, #32833)
--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:4>

[Django]

#35545: Fix create_permissions LookupErrors
----------------------------------+------------------------------------
Reporter: Csirmaz Bendegúz | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------

Changes (by Sarah Boyce):

* cc: Mariusz Felisiak, Simon Charette (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:5>

[Django]

#35545: Fix create_permissions LookupErrors
----------------------------------+---------------------------------------
Reporter: Csirmaz Bendegúz | Owner: Sarah Boyce
Type: Bug | Status: assigned

Component: contrib.auth | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

----------------------------------+---------------------------------------
Changes (by Sarah Boyce):

* has_patch: 0 => 1
* owner: nobody => Sarah Boyce
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:6>

[Django]

#35545: Fix create_permissions LookupErrors
-------------------------------------+-------------------------------------

Reporter: Csirmaz Bendegúz | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: contrib.auth | Version: 5.1
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:7>

[Django]

#35545: Fix create_permissions LookupErrors
-------------------------------------+-------------------------------------
Reporter: Csirmaz Bendegúz | Owner: Sarah
| Boyce

Type: Bug | Status: closed
Component: contrib.auth | Version: 5.1
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"f1705c8780c0a7587654fc736542d55fe4a7f29b" f1705c8]:
{{{#!CommitTicketReference repository=""
revision="f1705c8780c0a7587654fc736542d55fe4a7f29b"
Fixed #35545, Refs #32833 -- Fixed ContentTypeManager.get_for_models()
crash in CreateModel migrations.

Thank you to Csirmaz Bendegúz for the report and Simon Charettes for the
review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:8>

[Django]

#35545: Fix create_permissions LookupErrors
-------------------------------------+-------------------------------------
Reporter: Csirmaz Bendegúz | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: contrib.auth | Version: 5.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"63178036b3384a97dd2547ecfe8349c4b195324a" 6317803]:
{{{#!CommitTicketReference repository=""
revision="63178036b3384a97dd2547ecfe8349c4b195324a"
[5.1.x] Fixed #35545, Refs #32833 -- Fixed

ContentTypeManager.get_for_models() crash in CreateModel migrations.

Thank you to Csirmaz Bendegúz for the report and Simon Charettes for the
review.

Backport of f1705c8780c0a7587654fc736542d55fe4a7f29b from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35545#comment:9>