[Django] #23466: Removing seconds from locale formats
Django
--------------------------------------+--------------------
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Translations | Version: 1.6
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
As discussed on the Django-developers mailing list (Subject: Unifying
locale time formats).
I propose the removal of seconds from standard time output formats. Commit
coming sometime this week.
--
Ticket URL: <https://code.djangoproject.com/ticket/23466>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* needs_better_patch: => 0
* component: Translations => Internationalization
* needs_tests: => 0
* version: 1.6 => master
* needs_docs: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:1>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Description changed by maltebeckmann:
Old description:
> As discussed on the Django-developers mailing list (Subject: Unifying
> locale time formats).
>
> I propose the removal of seconds from standard time output formats.
> Commit coming sometime this week.
New description:
As discussed on the Django-developers mailing list (Subject: Unifying
locale time formats).
I propose the removal of seconds from standard time output formats. Commit
coming sometime this week.
Here it is: https://github.com/maltebeckmann/django/tree/ticket_23466
--
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:2>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Description changed by maltebeckmann:
Old description:
> As discussed on the Django-developers mailing list (Subject: Unifying
> locale time formats).
>
> I propose the removal of seconds from standard time output formats.
> Commit coming sometime this week.
>
New description:
As discussed on the Django-developers mailing list (Subject: Unifying
locale time formats).
I propose the removal of seconds from standard time output formats.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:3>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by wimfeijen):
Hi, nice work!
Let's mention this change in the release notes! :)
under Internationalization:
"Removed seconds in locale time formats."
or something like that.
Can you do that please?
In addition, I was wondering whether we should unify G:i and H:i (hours
with or without leading zeros). I'll ask on the mailing list.
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:4>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
Malte, could you please make a pull request from your branch?
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:5>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by maltebeckmann):
@Claude
Created the pull request: https://github.com/django/django/pull/3218 (took
me a bit, still new to this process).
@Wim
I also noticed a number of issues in regard to uniformity of times and
dates. I am, however, wondering whether there is the odd locale in which
time does require a leading zero. Either way, I think there are lots of
inconsistencies that should be addressed. But I think this needs to be
addressed in another ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:6>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* needs_docs: 0 => 1
* has_patch: 0 => 1
Comment:
Thanks, the patch is fine. Now only a release note is missing.
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:7>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Comment (by maltebeckmann):
Cheers! The release note is not up to me though, is it?
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:8>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
Yes it is :-) See `docs/releases/1.8.txt`. A good Django patch has usually
both tests and docs. In this specific case, tests are not so useful.
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:9>
Django
Reporter: maltebeckmann | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Internationalization | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"22bfc451467ec6e13044a87a97cf00e9f8a845e4"]:
{{{
#!CommitTicketReference repository=""
revision="22bfc451467ec6e13044a87a97cf00e9f8a845e4"
Fixed #23466 -- Removed seconds from all locale time output formats.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23466#comment:10>