Re: [Django] #35358: Rename BaseConstraint.

Django

unread,

Apr 12, 2024, 8:08:31 PM4/12/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: avish
Type: | mehta
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 6.0 | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by avish mehta):

* owner: nobody => avish mehta
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Apr 12, 2024, 8:10:22 PM4/12/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------

Reporter: Simon Charette | Owner: (none)
Type: | Status: new
Cleanup/optimization |

* owner: avish mehta => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:3>

Django

unread,

Apr 12, 2024, 8:10:41 PM4/12/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------

Reporter: Simon Charette | Owner: avish
Type: | mehta
Cleanup/optimization | Status: assigned

* owner: (none) => avish mehta

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:4>

Django

unread,

Apr 12, 2024, 8:44:11 PM4/12/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: avish
Type: | mehta
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 6.0 | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Simon Charette):

To make it clear, this ticket cannot be worked on until Django 6.0 which
will remove the deprecation shim for `CheckConstraint.check` in favor of
`.condition` which will allow `BaseConstraint.check` to be reclaimed.
--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:5>

Django

unread,

Aug 5, 2024, 8:03:56 AM8/5/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------

Reporter: Simon Charette | Owner: (none)
Type: | Status: closed
Cleanup/optimization |

Component: Database layer | Version: dev
(models, ORM) |

Severity: Normal | Resolution: fixed

Changes (by Sourav Kumar):

* resolution: => fixed
* status: new => closed

Comment:

The above issue has been resolved in the below PR.
https://github.com/django/django/pull/18448
--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:6>

Django

unread,

Aug 5, 2024, 8:08:21 AM8/5/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: (none)

Type: | Status: new

Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:

Changes (by Mariusz Felisiak):

* resolution: fixed =>
* status: closed => new

Comment:

Replying to [comment:6 Sourav6971]:

> The above issue has been resolved in the below PR.
> https://github.com/django/django/pull/18448

Ticket is fixed when PR is merged. Secondly, as Simon already
[https://code.djangoproject.com/ticket/35358?replyto=6#comment:5
mentioned], this ticket cannot be worked on until Django 6.0. Please work
on "Accepted" tickets, not tickets marked as "Someday/maybe".
--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:7>

Django

unread,

Aug 5, 2024, 8:10:54 AM8/5/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 6.0 | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sourav Kumar):

So sorry for not paying attention. Got carried away with the excitement of
solving my first issue.

Replying to [comment:7 Mariusz Felisiak]:

> Replying to [comment:6 Sourav6971]:
> > The above issue has been resolved in the below PR.
> > https://github.com/django/django/pull/18448
>
> Ticket is fixed when PR is merged. Secondly, as Simon already
[https://code.djangoproject.com/ticket/35358?replyto=6#comment:5
mentioned], this ticket cannot be worked on until Django 6.0. Please work
on "Accepted" tickets, not tickets marked as "Someday/maybe".
--

Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:8>

Django

unread,

Sep 11, 2024, 1:53:33 PM9/11/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 6.0 | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by AryanSingh1112):

Sir, please give this issue to me for solving it.
--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:9>

Django

unread,

Sep 11, 2024, 2:14:07 PM9/11/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 6.0 | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Simon Charette):

Please a take a minute to read the context of the ticket; **this ticket
cannot be worked on until Django 6.0**
--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:10>

Django

unread,

Oct 29, 2024, 1:14:17 PM10/29/24

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 6.0 | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by YashRaj1506):

* cc: YashRaj1506 (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:11>

Django

unread,

Jan 21, 2025, 7:56:26 AM1/21/25

to django-...@googlegroups.com

Keywords: 6.0 | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* stage: Someday/Maybe => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:12>

Django

unread,

Feb 6, 2025, 4:33:54 PM2/6/25

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------

Reporter: Simon Charette | Owner: Mariusz
Type: | Felisiak
Cleanup/optimization | Status: assigned

Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 6.0 | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* owner: (none) => Mariusz Felisiak

* status: new => assigned

Comment:

[https://github.com/django/django/pull/19148 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:13>

Django

unread,

Feb 17, 2025, 12:44:11 PM2/17/25

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Mariusz
Type: | Felisiak
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:

Keywords: 6.0 | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:14>

Django

unread,

Feb 19, 2025, 2:27:41 PM2/19/25

to django-...@googlegroups.com

#35358: Rename BaseConstraint._check() to check()
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Mariusz
Type: | Felisiak

Cleanup/optimization | Status: closed

Component: Database layer | Version: dev
(models, ORM) |

Severity: Normal | Resolution: fixed

Changes (by GitHub <noreply@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"65c46d6932c0956d2988d13ec3d9ab3ef9d96d61" 65c46d69]:
{{{#!CommitTicketReference repository=""
revision="65c46d6932c0956d2988d13ec3d9ab3ef9d96d61"
Fixed #35358, Refs #35234 -- Renamed _check() methods to check() for
constraints.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35358#comment:15>

Reply all

Reply to author

Forward

Re: [Django] #35358: Rename BaseConstraint._check() to check()

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django