[Django] #27318: No return of failed values with memcached.set_many()
Django
-------------------------------------+--------------------
Reporter: Florent Fourcot | Owner: nobody
Type: Bug | Status: new
Component: Core (Cache system) | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+--------------------
The set_many method of MemcachedBackend does not return anything, even if
both python-memcached and pylibmc libraries return the list of failing
keys.
As result, the backend can fail silently.
--
Ticket URL: <https://code.djangoproject.com/ticket/27318>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Florent Fourcot | Owner: nobody
Type: Bug | Status: new
Component: Core (Cache system) | Version: 1.10
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 0
UI/UX: 0 |
Changes (by Florent Fourcot):
* Attachment "0001-Fixed-27318-Return-list-of-failing-keys-with-
set_man.patch" added.
Django
--------------------------------------+------------------------------------
Reporter: Florent Fourcot | Owner: nobody
Component: Core (Cache system) | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: => 0
* needs_tests: => 1
* needs_docs: => 0
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
As noted on the [https://github.com/django/django/pull/7346 PR], tests are
needed.
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:1>
Django
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Cleanup/optimization | Status: assigned
Component: Core (Cache system) | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Changes (by Olivier Tabone):
* owner: nobody => Olivier Tabone
* status: new => assigned
Comment:
claim the ticket, created a new
[https://github.com/django/django/pull/7520 PR] (the other one was just a
one liner).
please review the pr.
Added tests, as recommended in the original PR review.
updated the docs
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
* needs_tests: 1 => 0
Comment:
I left comments for improvement on the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Olivier Tabone):
* needs_better_patch: 1 => 0
Comment:
updated the [https://github.com/django/django/pull/7520 PR], please feel
free to review and comment.
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Olivier Tabone):
updated the [https://github.com/django/django/pull/7520 PR]
rebase from master
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Component: Core (Cache system) | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a027447f5606d60358e5da76c0e8233732ad2b17" a027447]:
{{{
#!CommitTicketReference repository=""
revision="a027447f5606d60358e5da76c0e8233732ad2b17"
Fixed #27318 -- Made cache.set_many() return the list of failed keys.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"abacd09f07f4bb0aa1a3a32bc6e3c3570fa76912" abacd09]:
{{{
#!CommitTicketReference repository=""
revision="abacd09f07f4bb0aa1a3a32bc6e3c3570fa76912"
Refs #27318 -- Made DummyCache.set_many() return a list for consistency
with other backends.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Florent Fourcot | Owner: Olivier
Type: | Tabone
Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"ea901eb9ad951b551ef28ab6c68296ca5888a1cb" ea901eb]:
{{{
#!CommitTicketReference repository=""
revision="ea901eb9ad951b551ef28ab6c68296ca5888a1cb"
[2.0.x] Refs #27318 -- Made DummyCache.set_many() return a list for
consistency with other backends.
Backport of abacd09f07f4bb0aa1a3a32bc6e3c3570fa76912 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27318#comment:10>