Re: [Django] #33658: Document the "blank" argument of forms.ModelChoiceField.

[Django]

#33658: Document the "blank" argument of forms.ModelChoiceField.
-------------------------------------+-------------------------------------
Reporter: Carsten Fuchs | Owner: Alokik
Type: | Roy
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Alokik Roy):

* owner: nobody => Alokik Roy
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/33658#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#33658: Document the "blank" argument of forms.ModelChoiceField.
-------------------------------------+-------------------------------------
Reporter: Carsten Fuchs | Owner: Alokik
Type: | Roy
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Carsten Fuchs):

Thanks Alokik Roy for anticipating and taking this! ;-)

--
Ticket URL: <https://code.djangoproject.com/ticket/33658#comment:3>

[Django]

#33658: Document the "blank" argument of forms.ModelChoiceField.
-------------------------------------+-------------------------------------
Reporter: Carsten Fuchs | Owner: Alokik
Type: | Roy
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Alokik Roy):

* has_patch: 0 => 1

Comment:

PR [https://github.com/django/django/pull/15645]

--
Ticket URL: <https://code.djangoproject.com/ticket/33658#comment:4>

[Django]

#33658: Document the "blank" argument of forms.ModelChoiceField.
-------------------------------------+-------------------------------------
Reporter: Carsten Fuchs | Owner: Alokik
Type: | Roy
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/33658#comment:5>

[Django]

#33658: Document the "blank" argument of forms.ModelChoiceField.
-------------------------------------+-------------------------------------
Reporter: Carsten Fuchs | Owner: Alokik
Type: | Roy
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Alokik Roy):

* needs_better_patch: 1 => 0

Comment:

Implemented suggested changes

--
Ticket URL: <https://code.djangoproject.com/ticket/33658#comment:6>

[Django]

#33658: Document the "blank" argument of forms.ModelChoiceField.
-------------------------------------+-------------------------------------
Reporter: Carsten Fuchs | Owner: Alokik
Type: | Roy
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/33658#comment:7>

[Django]

#33658: Document the "blank" argument of forms.ModelChoiceField.
-------------------------------------+-------------------------------------
Reporter: Carsten Fuchs | Owner: Alokik
Type: | Roy

Cleanup/optimization | Status: closed
Component: Documentation | Version: 4.0
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"df22566748faa7bd16a9616617875e8370cbe4ee" df225667]:
{{{
#!CommitTicketReference repository=""
revision="df22566748faa7bd16a9616617875e8370cbe4ee"
Fixed #33658 -- Doc'd ModelChoiceField.blank attribute.

Thanks Mariusz Felisiak for reviewing.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33658#comment:8>

[Django]

#33658: Document the "blank" argument of forms.ModelChoiceField.
-------------------------------------+-------------------------------------
Reporter: Carsten Fuchs | Owner: Alokik
Type: | Roy
Cleanup/optimization | Status: closed
Component: Documentation | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"256db5c0482c7cef1e1754a8a853d58f6c6299e9" 256db5c0]:
{{{
#!CommitTicketReference repository=""
revision="256db5c0482c7cef1e1754a8a853d58f6c6299e9"
[4.0.x] Fixed #33658 -- Doc'd ModelChoiceField.blank attribute.

Thanks Mariusz Felisiak for reviewing.

Backport of df22566748faa7bd16a9616617875e8370cbe4ee from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33658#comment:9>