Re: [Django] #36897: Improve repercent_broken_unicode() performance

[Django]

#36897: Improve repercent_broken_unicode() performance
-------------------------------------+-------------------------------------
Reporter: Tarek Nakkouch | Owner: Harsh007
Type: | Status: assigned
Cleanup/optimization |
Component: Utilities | Version: 6.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Harsh007):

* cc: Harsh007 (added)
* owner: (none) => Harsh007
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36897#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36897: Improve repercent_broken_unicode() performance
-------------------------------------+-------------------------------------

Reporter: Tarek Nakkouch | Owner: (none)
Type: | Status: new

Cleanup/optimization |
Component: Utilities | Version: 6.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Harsh007):

* owner: Harsh007 => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/36897#comment:3>

[Django]

#36897: Improve repercent_broken_unicode() performance
-------------------------------------+-------------------------------------
Reporter: Tarek Nakkouch | Owner:

Type: | beestarkdev
Cleanup/optimization | Status: assigned

Component: Utilities | Version: 6.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by beestarkdev):

* owner: (none) => beestarkdev

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36897#comment:4>

[Django]

#36897: Improve repercent_broken_unicode() performance
-------------------------------------+-------------------------------------
Reporter: Tarek Nakkouch | Owner:
Type: | beestarkdev
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 6.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by beestarkdev):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/36897#comment:5>

[Django]

#36897: Improve repercent_broken_unicode() performance
-------------------------------------+-------------------------------------
Reporter: Tarek Nakkouch | Owner:
Type: | beestarkdev
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 6.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by beestarkdev):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36897#comment:6>

[Django]

#36897: Improve repercent_broken_unicode() performance
-------------------------------------+-------------------------------------
Reporter: Tarek Nakkouch | Owner:
Type: | beestarkdev
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 6.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by beestarkdev):

Hi, here is the pull request: https://github.com/django/django/pull/20626

This is my first time ever contributing to open source so please feel free
to give me feedback if there's anything I can improve on.

I have attempted to add another optimization to this function in addition
to the recommendation here. I will post the testing/benchmarking
methodologies as well in the pull request for full transparency. Thank
you!
--
Ticket URL: <https://code.djangoproject.com/ticket/36897#comment:7>